T89897: Implement hiding data source names spreadsheet
Needs ReviewPublic
Actions

Authored by Angus Stanton (abstanton) on Apr 21 2022, 12:30 AM.

Details

Reviewers

Hans Goudey (HooglyBoogly)
Dalai Felinto (dfelinto)

Maniphest Tasks

T89897: Semi-collapse spreadsheet editor navigation tab showing icons + numbers only

Summary

Would be nice if maybe the indent changed? Looks a bit
odd when there's still an indent. Maybe the header (e.g Mesh)
should be differentiated in a way other than indent level

Diff Detail

Repository

rB Blender

Branch

T89897-semi-collapse-spreadsheet (branched from master)

Build Status

Buildable 21724
Build 21724: arc lint + arc unit

Event Timeline

Angus Stanton (abstanton) requested review of this revision.Apr 21 2022, 12:30 AM

Angus Stanton (abstanton) created this revision.

Harbormaster completed remote builds in B21724: Diff 50631.Apr 21 2022, 12:30 AM

Angus Stanton (abstanton) edited the summary of this revision. (Show Details)Apr 21 2022, 12:30 AM

Angus Stanton (abstanton) retitled this revision from T89897: Implement hiding name on collapse to T89897: Implement hiding data source names spreadsheet.

Angus Stanton (abstanton) added a reviewer: Hans Goudey (HooglyBoogly).Apr 21 2022, 10:27 AM

Angus Stanton (abstanton) added a reviewer: Dalai Felinto (dfelinto).

Angus Stanton (abstanton) edited the summary of this revision. (Show Details)Apr 21 2022, 12:04 PM

Angus Stanton (abstanton) edited the summary of this revision. (Show Details)

I think this might look nice when the region is one or two icon-widths wide, but until it gets there, it mostly looks like text is missing. So I'd suggest lowing the threshold a fair amount.

I also think it would be helpful to have some visual mockups that ignore the constraints of current code. In other words, it would be nice to know what would this smaller view would look like ideally.

Big picture I like the idea-- it would be nice to have the option to use the spreadsheet with a smaller width for the editor, and there is some precedent with things like the names for tools in the 3D view toolbar.

Yeah, I'm not happy with how it looks even with reducing the threshold a lot.
I did these quick mockups, what do you think? I removed the icons from the headers to make it clearer they're headers, not buttons. I think I should've kept the icons for instances n volume grids so that they're consistent with the buttons?