Page MenuHome
Differential D14740

Render: Update lightgroup membership in objects and world if lightgroup is renamed
ClosedPublic
Actions

Authored by Lukas Stockner (lukasstockner97) on Apr 23 2022, 11:09 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rB6db059e3d7c3: Render: Update lightgroup membership in objects and world if lightgroup is…
Summary

As discussed, this only updates objects in and the world of the scene to which the view layer belongs, which also avoids the problem of not having a BMain available.

Diff Detail

Repository
rB Blender
Branch
rename-lightgroups (branched from master)
Build Status
Buildable 21766
Build 21766: arc lint + arc unit

Event Timeline

Lukas Stockner (lukasstockner97) requested review of this revision.Apr 23 2022, 11:09 PM
Lukas Stockner (lukasstockner97) created this revision.
Harbormaster completed remote builds in B21766: Diff 50743.Apr 23 2022, 11:09 PM
Lukas Stockner (lukasstockner97) mentioned this in T78008: Cycles: Light Group render passes improvements.Apr 23 2022, 11:13 PM
Gavriel Lavi (Gavriel5578) awarded a token.Apr 24 2022, 5:22 PM
Brecht Van Lommel (brecht) requested changes to this revision.Apr 25 2022, 4:24 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/blenkernel/intern/layer.c
2603

You have to make sure to not edit linked objects (ID_IS_LINKED(ob)) and worlds.

This revision now requires changes to proceed.Apr 25 2022, 4:24 PM
Alaska (Alaska) awarded a token.Apr 28 2022, 10:44 AM
Alaska (Alaska) added a subscriber: Alaska (Alaska).Apr 28 2022, 11:03 AM
Lukas Stockner (lukasstockner97) updated this revision to Diff 51518.May 16 2022, 12:54 PM

Included check for linked objects and world.

Just to make sure, ID_IS_OVERRIDE_LIBRARY is not relevant here?

Harbormaster completed remote builds in B22114: Diff 51518.May 16 2022, 12:54 PM
Brecht Van Lommel (brecht) accepted this revision.May 16 2022, 2:25 PM

ID_IS_OVERRIDE_LIBRARY is not relevant. Overrides are local datablocks that are editable,

This revision is now accepted and ready to land.May 16 2022, 2:25 PM
Closed by commit rB6db059e3d7c3: Render: Update lightgroup membership in objects and world if lightgroup is… (authored by Lukas Stockner (lukasstockner97)). · Explain WhyJul 24 2022, 9:34 PM
This revision was automatically updated to reflect the committed changes.
Lukas Stockner (lukasstockner97) added a commit: rB6db059e3d7c3: Render: Update lightgroup membership in objects and world if lightgroup is….

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
3 lines
intern/
27 lines
makesrna/
intern/
2 lines

Diff 50743

View Options

source/blender/blenkernel/BKE_layer.h

Loading...
View Options

source/blender/blenkernel/intern/layer.c

Loading...
View Options

source/blender/makesrna/intern/rna_scene.c

Loading...