Fix T97500: NLA strip names are no longer fully rendered when they shouldn't be
ClosedPublic
Actions

Authored by Colin Basnett (cmbasnett) on Apr 24 2022, 1:40 AM.

Details

Reviewers

Sybren A. Stüvel (sybren)
Brad Clark (RiggingDojo)

Commits

rB8d53ead69bb5: Fix T97500: NLA strip names drawn outside strip

Summary

This diff fixes T97500: NLA strip names can be fully rendered when they shouldn't be.

I just removed the logic that for some reason decided it was a good idea to draw the entire string if the min/max were swapped. The code is from 2005 and I'm pretty sure it was broken when it was written.

This function is only called in two places, once here in the NLA, and the VSE. The bug only materializes in the NLA though.

Old:

New:

Diff Detail

Repository: rB Blender

Event Timeline

Colin Basnett (cmbasnett) requested review of this revision.Apr 24 2022, 1:40 AM

Colin Basnett (cmbasnett) created this revision.

Colin Basnett (cmbasnett) retitled this revision from FNLA strip names are no longer fully rendered when they shouldn't be to Fix T97500: NLA strip names are no longer fully rendered when they shouldn't be.Apr 24 2022, 1:44 AM

Colin Basnett (cmbasnett) edited the summary of this revision. (Show Details)

Colin Basnett (cmbasnett) added projects: Animation & Rigging, User Interface.

Colin Basnett (cmbasnett) edited the summary of this revision. (Show Details)

Colin Basnett (cmbasnett) edited the summary of this revision. (Show Details)Apr 24 2022, 1:53 AM

Brad Clark (RiggingDojo) awarded a token.Apr 24 2022, 8:16 PM

Brad Clark (RiggingDojo) added reviewers: Sybren A. Stüvel (sybren), Brad Clark (RiggingDojo).