BGE: Add bounding volume support for the user, Fix T33191.
AbandonedPublic
Actions

Authored by Porteries Tristan (panzergame) on Aug 22 2015, 12:29 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Thomas Szepe (hg1)
Ulysse Martin (youle)
Jorge Bernal (lordloki)
Quentin Wenger (Matpi)
Mitchell Stokes (moguri)
Angus Hollands (agoose77)

Maniphest Tasks

T33191: Occlusion replaced mesh bug

Summary

Previously when a mesh was deformed the bounding volume or AABB was not updated and it caused some wrong frustum culling.
To fix it i added an AABB compute in RAS_MeshObject and in RAS_Deformer, which are updated each time the mesh or deformer is modified but as Moguri noticed it can spent 10% spend more time than deforme the mesh.
So the solution is to add an option to automatically update or not the AABB or use a predefined AABB based on a mesh.
It fixes T33191.

Diff Detail

Repository: rB Blender
Branch: ge_aabb_support

Event Timeline

Porteries Tristan (panzergame) updated this revision to Diff 4898.Aug 22 2015, 12:29 PM

Porteries Tristan (panzergame) retitled this revision from to BGE: Add bounding volume support for the user and frustum bugs fix..

Porteries Tristan (panzergame) added reviewers: Mitchell Stokes (moguri), Campbell Barton (campbellbarton), Thomas Szepe (hg1), Angus Hollands (agoose77), Jorge Bernal (lordloki), Ulysse Martin (youle), Quentin Wenger (Matpi).

Porteries Tristan (panzergame) updated this object.

Porteries Tristan (panzergame) updated this object.Aug 22 2015, 1:12 PM

You can't remove OB_NEVER_DO_ACTIVITY_CULLING just because it's not exposed in the UI and not even mention it in the log/patch description. And even if you propose removing it (after some investigation with git blame, git log, ...), I would suggest, at the time of commit, to do it as a separate commit.

Also I would leave cleanups (such as SetMeshModified) outside this patch too.

Hey! I'm not experienced enough to review your code but do you think it can be usefull in such: http://blenderartists.org/forum/showthread.php?379862-Armature-animation-does-not-start-until-it-is-watching-the-camera situation? I wait your .blend example to test your patch and have a better comprehension of what is an AABB. A question: Can we see this box when we check "physics visualization"?... That's not really physics but it would be nice to have a button to see this box.

Jacob Merrill (blueprintrandom) awarded a token.Aug 30 2015, 4:51 AM

Jacob Merrill (blueprintrandom) added a subscriber: Jacob Merrill (blueprintrandom).

Campbell Barton (campbellbarton) added inline comments.Sep 2 2015, 1:14 PM

source/gameengine/Ketsji/KX_BoundingVolume.h
45 ↗	(On Diff #4898)	This seems overkill, This needs to point to the game-object anyway, so having a separate object seems a bit of useless de-coupling. For eg, if you wanted to use a BoudingVolume elsewhere from Python. You couldn't use this class because its specifically a `KX_GameObjectBoundingVolume`