Switch viewport shading for color tools in solid mode
ClosedPublic
Actions

Authored by Ramil Roosileht (Limarest) on Apr 26 2022, 8:56 PM.

Details

Reviewers

Julien Kaspar (JulienKaspar)
Joseph Eagar (joeedh)
Jeroen Bakker (jbakker)

Maniphest Tasks

T97613: Mask by Color and Color Filter tools don't switch viewport shading

Commits

rB90042b7d7966: Switch viewport shading for color tools in solid mode

Summary

This patch implements T97613, switching viewport shading when using Color Filter and Mask By Color

ALSO, this patch makes it so viewport shading color switches only when SOLID mode is chosen, to prevent color switching when using other shading modes, without user noticing it.

Diff Detail

Repository: rB Blender

Event Timeline

Ramil Roosileht (Limarest) requested review of this revision.Apr 26 2022, 8:56 PM

Ramil Roosileht (Limarest) created this revision.

Ramil Roosileht (Limarest) added a task: T97613: Mask by Color and Color Filter tools don't switch viewport shading.

Joseph Eagar (joeedh) accepted this revision.Apr 27 2022, 7:54 PM

This revision is now accepted and ready to land.Apr 27 2022, 7:54 PM

This works great!

Updated patch for tools to only switch in solid mode

Great! This behaviour makes the most sense with the current design.

I would prefer this to be in 3.2 as well as it fixes an issue we are aware of, but users haven't reported as a bug. will notify Thomas as he wants to be kept in the loop of these kind of changes.

Fine for me to land in Blender 3.2.

Closed by commit rB90042b7d7966: Switch viewport shading for color tools in solid mode (authored by Ramil Roosileht (Limarest), committed by Jeroen Bakker (jbakker)). · Explain WhyMay 6 2022, 12:30 PM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) added a commit: rB90042b7d7966: Switch viewport shading for color tools in solid mode.