UI: Fix consistency issues with tooltips and icons
ClosedPublic
Actions

Authored by Ethan Hall (Ethan1080) on Apr 27 2022, 12:14 AM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Commits

rB1425b356b842: UI: Fix consistency issues with attribute tooltips and icons

Summary

This patch modifies tooltips of attributes and UV maps to resolve
inconsistencies.
This patch also restores the vertex color icon that went missing from
the UI lists when color attributes replaced vertex colors.

Completes task: T97614

Here is a quick comparison for the icon change:

3.1.2:
3.2.0 Current:
This Patch:

Let me know if I missed something or need to revert a change.

Diff Detail

Repository

rB Blender

Branch

col_attr_consistency (branched from master)

Build Status

Buildable 21828
Build 21828: arc lint + arc unit

Event Timeline

Ethan Hall (Ethan1080) requested review of this revision.Apr 27 2022, 12:14 AM

Ethan Hall (Ethan1080) created this revision.

Harbormaster completed remote builds in B21828: Diff 50864.Apr 27 2022, 12:14 AM

Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)Apr 27 2022, 12:18 AM

Ethan Hall (Ethan1080) added projects: User Interface, Sculpt, Paint & Texture, Geometry Nodes.

Ethan Hall (Ethan1080) added subscribers: Julien Kaspar (JulienKaspar), Joseph Eagar (joeedh).

Ethan Hall (Ethan1080) added a subscriber: Hans Goudey (HooglyBoogly).Apr 27 2022, 9:15 PM

This all looks fine to me. I would make the description/title a bit more general though, since this affects more than color attributes.

The only thing I'm not sure about are the icons. Could you make a case for that change? Or maybe it was mentioned in a module meeting?

In D14768#397398, @Hans Goudey (HooglyBoogly) wrote:

The only thing I'm not sure about are the icons. Could you make a case for that change? Or maybe it was mentioned in a module meeting?

Color attributes apply to vertices and face corners, and they replace vertex colors. Therefore, I think it is appropriate to continue using the vertex color icon for version consistency and to distinguish the color attribute UI list from the general attribute UI list. The regular color icon is used for color palettes and does not indicate that the color attribute is a property of the geometry/mesh (see the similarity of the vertex color and UV map icons).

(See the comparison I added to the description)

Ethan Hall (Ethan1080) retitled this revision from Geometry Attribute UI: Fix consistency issues to UI: Fix consistency issues with tooltips and icons.Apr 27 2022, 10:27 PM

Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)

Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)Apr 28 2022, 4:03 AM

Looks good to me. It makes a lot of the tooltips more consistent and clear.
The use of the icons is fine I think. It helps to recognise them elsewhere in Blender as color attributes.

Accepting with just one tweak requested

source/blender/makesrna/intern/rna_attribute.c
1016	Since this is a property rather than a function, I think "Set" isn't standard here, I'd go with `The index of the color attribute used as a fallback for rendering` (I think the fallback thing is correct)

This revision is now accepted and ready to land.Apr 28 2022, 6:07 PM

Hans Goudey (HooglyBoogly) added inline comments.Apr 28 2022, 6:08 PM