Page MenuHome

Fix T97627: Revert Window Redraw When Saving
ClosedPublic

Authored by Harley Acheson (harley) on Apr 27 2022, 5:42 PM.

Details

Summary

Removal of the WM_redraw_windows call in wm_file_write introduced
in rB7a9cfd08a8d7415ff004809cf62570be9152273e as that can cause
crashing while saving from a script.


Calling WM_redraw_windows in wm_file_write had been added in D12507 to ensure that there were no menus shown open during the process to ensure screenshot-type thumbnails did not capture them. However we don't currently have a reliable way to do this that does not cause crashing when saving from scripts, as illustrated in T92704 & T97627. This patch removes that call and adds a descriptive comment in its place.

Diff Detail

Repository
rB Blender

Event Timeline

Campbell Barton (campbellbarton) added inline comments.
source/blender/windowmanager/intern/wm_files.c
1763–1765

Use * prefixed block comments, otherwise LGTM.

This revision is now accepted and ready to land.Apr 27 2022, 11:49 PM

Updating to incorporate changes requested by review.