Page MenuHome

Fix T97151: Curve vertex parenting crash with dependency cycle
ClosedPublic

Authored by Hans Goudey (HooglyBoogly) on Apr 27 2022, 8:04 PM.

Details

Summary

When the object's position depends on the geometry and the geometry
depends on the object's position, we can't count on the object's
evaluated geometry to be available. Lattices and mesh objects have
equivalent checks in this vertex parenting function.

Diff Detail

Repository
rB Blender

Event Timeline

Indeed there are more places doing similar check. Don't think we can do better than this "for now".
I'd rephtrase the comment a bit to increase "information density" :) But wouldn't worry about re-iterating on the review for that.

source/blender/blenkernel/intern/object.cc
3259–3260

Not sure the statement about weird depsgraph failure brings much information/ I'd rephrase this comment to state facts. Something in-between of lines:

/* It is possible that dependency cycle in the depsgraph was resolvedi n a way that caused this object evaluated prior its dependencies. In this case curve cache will be nullptr. */
This revision is now accepted and ready to land.Apr 28 2022, 10:26 AM

Great, your comment is much nicer. Thanks!