Color Attribute: Add menu QoL improvements
ClosedPublic
Actions

Authored by Ethan Hall (Ethan1080) on Apr 28 2022, 12:12 AM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Commits

rB024386bb891d: UI: Improvements to "Add Color Attribute" menu

Summary

Allow the session to save the choice for domain and data type since
it is highly likely that the user intends to use the same settings
for subsequent color attributes.

Use expanded button selectors for domain and data type since there
are only two options for each.

Original	Patch

Diff Detail

Repository

rB Blender

Branch

color_attr_add_qol (branched from master)

Build Status

Buildable 21852
Build 21852: arc lint + arc unit

Event Timeline

Ethan Hall (Ethan1080) requested review of this revision.Apr 28 2022, 12:12 AM

Ethan Hall (Ethan1080) created this revision.

Harbormaster completed remote builds in B21852: Diff 50921.Apr 28 2022, 12:12 AM

I believe the only reason why PROP_SKIP_SAVE is currently used is that the add method was originally copied from the general geometry attribute methods where it doesn't make sense to save the selection.

Let's leave the name change out, since this patch aims to have functional changes it's nice to keep cleanup separate. Plus it's not obviously better IMO.

Can you add a before/after screenshot to the description so it's not necessary to compile the patch to test it?

Removing PROP_SKIP_SAVE is a great change, that shouldn't have been added in the first place I think.

This revision now requires changes to proceed.Apr 28 2022, 12:24 AM

In D14785#397441, @Hans Goudey (HooglyBoogly) wrote:

Let's leave the name change out, since this patch aims to have functional changes it's nice to keep cleanup separate. Plus it's not obviously better IMO.

Can you add a before/after screenshot to the description so it's not necessary to compile the patch to test it?

Removing PROP_SKIP_SAVE is a great change, that shouldn't have been added in the first place I think.

Yes, I will do that now.

Revert variable name changes

Harbormaster completed remote builds in B21853: Diff 50922.Apr 28 2022, 12:32 AM

Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)Apr 28 2022, 12:44 AM

Ethan Hall (Ethan1080) added projects: Sculpt, Paint & Texture, User Interface.

Ethan Hall (Ethan1080) edited the summary of this revision. (Show Details)

Thanks.
Okay, I feel a little skeptical about expanding the enum, since whenever a third option is added it will just need to be changed back. But it might make the popup a bit less intimidating for newer users, so I think it's okay.
Before I commit this, a quick +1 from the sculpt module about expanding the enum would be nice.

This revision is now accepted and ready to land.Apr 28 2022, 12:47 AM

Ethan Hall (Ethan1080) mentioned this in D14724: UI: Add color attribute create to canvas selector.Apr 28 2022, 1:26 AM

In D14785#397457, @Hans Goudey (HooglyBoogly) wrote:

Thanks.
Okay, I feel a little skeptical about expanding the enum, since whenever a third option is added it will just need to be changed back. But it might make the popup a bit less intimidating for newer users, so I think it's okay.

I think if we don't plan on adding a third option for 3.2 it is worth it (especially since it will ease the transition from vertex colors.)

Ramil Roosileht (Limarest) awarded a token.Apr 28 2022, 10:46 AM

Julien Kaspar (JulienKaspar) awarded a token.Apr 28 2022, 5:43 PM

Closed by commit rB024386bb891d: UI: Improvements to "Add Color Attribute" menu (authored by Ethan Hall (Ethan1080), committed by Hans Goudey (HooglyBoogly)). · Explain WhyApr 28 2022, 5:48 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB024386bb891d: UI: Improvements to "Add Color Attribute" menu.

San Rin (Kuwaaa_) mentioned this in D14733: Color Attribute: Add convert color attribute operation.May 12 2022, 5:55 PM