Page MenuHome
Differential D14794

VSE: Delete Strip and Data in one step
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on Apr 28 2022, 4:58 PM.

Details

Reviewers
Matias Mendiola (mendio)
Daniel Martinez Lara (pepeland)
Richard Antalik (ISS)
Maniphest Tasks
T97683: VSE: Add option for "Delete Strip and Data"
Commits
rB8c4bd02b067a: VSE: Delete Strip and Scene Data in one step
Summary

Actually, delete the strip only deletes the container, but not the linked data. This patch adds the option to delete the data also. This is very handy for storyboarding.

Note: Actual patch only supports Scene strips.

Diff Detail

Repository
rB Blender

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.Apr 28 2022, 4:58 PM
Antonio Vazquez (antoniov) created this revision.
Harbormaster completed remote builds in B21874: Diff 50955.Apr 28 2022, 4:58 PM
Antonio Vazquez (antoniov) added a task: T97683: VSE: Add option for "Delete Strip and Data".Apr 28 2022, 4:58 PM
Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)
Antonio Vazquez (antoniov) added reviewers: Matias Mendiola (mendio), Daniel Martinez Lara (pepeland).
Antonio Vazquez (antoniov) added projects: Video Sequencer, Grease Pencil.
Antonio Vazquez (antoniov) added a subscriber: Pablo Vazquez (pablovazquez).
Antonio Vazquez (antoniov) updated this revision to Diff 50957.Apr 28 2022, 5:09 PM
  • Fix compiler warning
Harbormaster completed remote builds in B21876: Diff 50957.Apr 28 2022, 5:09 PM
Antonio Vazquez (antoniov) updated this revision to Diff 50960.Apr 28 2022, 5:28 PM
  • Remove not supported types
Harbormaster completed remote builds in B21877: Diff 50960.Apr 28 2022, 5:28 PM
Julien Kaspar (JulienKaspar) added a subscriber: Julien Kaspar (JulienKaspar).Apr 29 2022, 7:45 PM
Antonio Vazquez (antoniov) retitled this revision from Sequencer: Delete Strip and Data in one step to VSE: Delete Strip and Data in one step.May 5 2022, 5:39 PM
Antonio Vazquez (antoniov) added a reviewer: Richard Antalik (ISS).
Antonio Vazquez (antoniov) updated this revision to Diff 51217.May 6 2022, 8:22 AM
  • Replace and Data with & Data
Harbormaster completed remote builds in B21994: Diff 51217.May 6 2022, 8:22 AM
Richard Antalik (ISS) accepted this revision.May 16 2022, 3:07 PM
Richard Antalik (ISS) added inline comments.
source/blender/editors/space_sequencer/sequencer_edit.c
1723–1737

This function looks quite weird - it returns value, but this is not used anywhere. Is that for any future work? Also there is switch statement with one branch only. Early return on non-scene strip would save 3 indentation levels.

This revision is now accepted and ready to land.May 16 2022, 3:07 PM
Antonio Vazquez (antoniov) updated this revision to Diff 51544.May 16 2022, 8:18 PM
  • Cleanup function
Harbormaster completed remote builds in B22122: Diff 51544.May 16 2022, 8:18 PM
Closed by commit rB8c4bd02b067a: VSE: Delete Strip and Scene Data in one step (authored by Antonio Vazquez (antoniov)). · Explain WhyMay 16 2022, 8:20 PM
This revision was automatically updated to reflect the committed changes.
Antonio Vazquez (antoniov) added a commit: rB8c4bd02b067a: VSE: Delete Strip and Scene Data in one step.
Vyacheslav (hitrpr) awarded a token.May 26 2022, 5:58 PM

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
7 lines
source/
blender/
editors/
space_sequencer/
29 lines

Diff 51545

View Options

release/scripts/startup/bl_ui/space_sequencer.py

Loading...
View Options

source/blender/editors/space_sequencer/sequencer_edit.c

Loading...