Curves: Support symmetry in curves sculpting brushes.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Apr 28 2022, 5:40 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T97441: Curves sculpting mirroring tools.

Commits

rB7dc94155f620: Curves: support symmetry in curves sculpting brushes

Summary

This adds support for X/Y/Z symmetry for all brushes in curves sculpt mode. In theory this can be extended to support radial symmetry, but that's not part of this patch.

It works by essentially applying a brush stroke multiple times with some transform. This is similar to how symmetry works in mesh sculpt mode, but is quite different from how it worked in the old hair system (there it tried to find matching hair strands on both sides of the surface; if none was found, symmetry didn't work).

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Apr 28 2022, 5:40 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B21878: Diff 50962.Apr 28 2022, 5:41 PM

Jacques Lucke (JacquesLucke) added a subscriber: Hans Goudey (HooglyBoogly).Apr 28 2022, 6:11 PM

Jacques Lucke (JacquesLucke) added a task: T97441: Curves sculpting mirroring tools..Apr 28 2022, 7:15 PM

Merge branch 'master' into curves-sculpt-symmetry
use symmetry in remaining brushes
use matrix for symmetry, this can also support radial symmetry (there are no ui options for this yet though)
don't use use_mesh_mirror_x on Object in rna

Harbormaster completed remote builds in B21921: Diff 51064.May 2 2022, 10:47 AM

Jacques Lucke (JacquesLucke) retitled this revision from Curves: Support symmetry in curves sculpting brushes. (WIP) to Curves: Support symmetry in curves sculpting brushes..May 2 2022, 11:19 AM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).

This looks mostly good, it's nice that using a transform allows for more complex uses of symmetry in the future.

I'm skeptical of the implementation for the delete brush though-- it looks like the actual delete operation is done potentially 8 times.
It would probably be better to keep track of all of the curves to remove then only do the actual deletion once.
Maybe this could be implemented with a more general utility to merge several IndexMasks (one from each symmetry transform).