Page MenuHome

Fix Object Font does not respect Text Offset X/Y
Needs ReviewPublic

Authored by Jacob Buchanan (jhbuchanan45) on May 1 2022, 5:26 PM.

Details

Summary

Fixes T95655

The curve offset (which is the same as the Text Offset X/Y in this case) was being taken away from the individual character transform x/y offset, which already included the curve offset.
Since the ct offset already includes the curve offset, this unapplied the curve/text offset, leading to the issue.

This fixes the 'object as font' implementation to respect the text offset X/Y. By extension, this fixes alignment for object fonts (Left/Right, Middle/Bottom etc.)to behave identically to regular text.

This is my first attempt to submit a patch to Blender, apologies in advance for anything stupid I've done.

Diff Detail

Event Timeline

Jacob Buchanan (jhbuchanan45) requested review of this revision.May 1 2022, 5:26 PM
Jacob Buchanan (jhbuchanan45) created this revision.
Campbell Barton (campbellbarton) requested changes to this revision.EditedJun 3 2022, 5:49 AM

This works as expected, the unused variables can now be removed and there is no need for parenthesis around ct->xof & ct->yof

This revision now requires changes to proceed.Jun 3 2022, 5:49 AM

Thanks for taking a look at this! That should be everything tidied up, sorry about that.

Jacob Buchanan (jhbuchanan45) planned changes to this revision.Jul 23 2022, 8:25 PM
Jacob Buchanan (jhbuchanan45) requested review of this revision.