Page MenuHome

Experiment - use lightness for saturation masking
Changes PlannedPublic

Authored by Ramil Roosileht (Limarest) on May 1 2022, 10:27 PM.

Details

Summary

This patch further changes saturation filter after D14808 by using HSL instead of HSV and using lightness as a mask instead of existing saturation.
This results in saving highlighted areas of the image, instead of losing detail like before.

Things to note:

  1. This is an experiment and we shouldn't merge it as is
  2. It will be best to add this as an option for the filter, I'll update the patch to do that later
  3. Old variable name for color is hsv_color, which doesn't make sense if saturation uses hsl. Will probably need a new one, maybe temp_color?

Video

Testfile

Diff Detail

Repository
rB Blender

Event Timeline

Ramil Roosileht (Limarest) requested review of this revision.May 1 2022, 10:27 PM
Ramil Roosileht (Limarest) created this revision.
Ramil Roosileht (Limarest) planned changes to this revision.May 1 2022, 10:34 PM
Ramil Roosileht (Limarest) edited the summary of this revision. (Show Details)
Ramil Roosileht (Limarest) edited the summary of this revision. (Show Details)

I'm wondering if there is any way of using the Implement generic slider in graph_slider_ops D9361 in here for a more coherent use of the tool.