Selecting Action channel in NLA set the context now sets the context in the N panel, as well as indicated the active selection
ClosedPublic
Actions

Authored by Nate Rupsis (nrupsis) on May 2 2022, 6:14 AM.

Details

Reviewers

Brad Clark (RiggingDojo)
Philipp Oeser (lichtwerk)
Sybren A. Stüvel (sybren)

Maniphest Tasks

T97372: NLA Sidebar tab doesn’t refresh on keyframe creation and there is no UI change to indicate action selection in the track list

Commits

rB61e8310b7581: NLA: improve visibility of action & active channel

Summary

Old:

The NLA sidebar didn't refresh with the creation of a new action.
There was no indication of the action channel being selected.

New:

NLA side bar now refreshed when keyframes are added (new action is created)
Clicking on the action channel now gives visual indication of being selected

Diff Detail

Repository

rB Blender

Branch

T97372 (branched from master)

Build Status

Buildable 21918
Build 21918: arc lint + arc unit

Event Timeline

Nate Rupsis (nrupsis) requested review of this revision.May 2 2022, 6:14 AM

Nate Rupsis (nrupsis) created this revision.

Harbormaster completed remote builds in B21918: Diff 51060.May 2 2022, 6:14 AM

Nate Rupsis (nrupsis) edited the summary of this revision. (Show Details)May 2 2022, 6:22 AM

Accepting from art/animator side of things

This revision is now accepted and ready to land.May 2 2022, 7:00 AM

Brad Clark (RiggingDojo) added a reviewer: Sybren A. Stüvel (sybren).May 2 2022, 7:01 AM

This revision now requires review to proceed.May 2 2022, 7:01 AM

/* unhandled currently, but may be interesting */ -- I guess at least one of those was interesting indeed!

There is still something strange going on. I can have two objects, each with their own Action. However, when I have the Cube as the active object, it still shows the TeapotAction. This Action stays shown even when the NLA shows CubeAction as the active one.

source/blender/editors/animation/anim_channels_edit.c
342	Try to keep such formatting changes out of the patch. That way it's easier to figure out which files (or even functions) are influenced by the change in functionality. This also goes for the other formatting changes (`nla_channels.c` only has those, for example).

This revision now requires changes to proceed.May 2 2022, 5:19 PM

I think the two actions are due to the filtering not being set to active

That's fine, but if the actions are both shown in the NLA, the active one should be shown in the sidebar.

fixing spacing in anim_channels_defines
fix spacing in nla_channels

Harbormaster completed remote builds in B21924: Diff 51069.May 2 2022, 5:39 PM

In D14820#398570, @Sybren A. Stüvel (sybren) wrote:

That's fine, but if the actions are both shown in the NLA, the active one should be shown in the sidebar.

That is the existing way it works, if the NLA isn't filtering to the selected/active object, the side panel doesn't use the view selection
the sidebar only updates with the selected/active action when filtering for selected object in the view, if not, then the user has to pick from the NLA what action to work on.

In D14820#398580, @Brad Clark (RiggingDojo) wrote:

That is the existing way it works, if the NLA isn't filtering to the selected/active object, the side panel doesn't use the view selection
the sidebar only updates with the selected/active action when filtering for selected object in the view, if not, then the user has to pick from the NLA what action to work on.

👍

I'll fix the last whitespace issue when landing the patch, no need to reupload.

source/blender/editors/animation/anim_channels_edit.c
343–344	Hah, some whitespace still snuck in. To avoid such changes, I'd recommend `git gui`. You can then even stage/unstage single lines, ensuring that you only put into the commit what you want to be in there. After staging you can press `Ctrl`+`J` to remove any unstaged change.

This revision is now accepted and ready to land.May 3 2022, 10:59 AM

Closed by commit rB61e8310b7581: NLA: improve visibility of action & active channel (authored by Nate Rupsis (nrupsis), committed by Sybren A. Stüvel (sybren)). · Explain WhyMay 3 2022, 12:02 PM

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) added a commit: rB61e8310b7581: NLA: improve visibility of action & active channel.

Brad Clark (RiggingDojo) retitled this revision from Selecting Action channel in NLA set the context now sets the context in the N pannel, as well as indicated the active selection to Selecting Action channel in NLA set the context now sets the context in the N panel, as well as indicated the active selection.May 3 2022, 4:45 PM

Thx again @Nate Rupsis (nrupsis) , sorry to be late here.
I usually dont review patches (at least not in a way that would empower to commit), but still, feel free to subscribe me to anything you put up, I will happily have a look if time permits.

Nate Rupsis (nrupsis) mentioned this in D16154: Fix T101275: Edited action in NLA dependency issue.Oct 5 2022, 5:38 PM