Page MenuHome
Differential D14826

Fix T97793, Fix T97795: Use correct defaults for missing values in new OBJ importer
ClosedPublic
Actions

Authored by Aras Pranckevicius (aras_p) on May 3 2022, 12:46 PM.

Details

Reviewers
Howard Trickey (howardt)
Maniphest Tasks
T97793: New OBJ importer: default value for missing "vt" values is incorrect (see T68249)
T97795: New OBJ importer: defaults a missing "-bm mult" value to be 0.0 but old importer uses 1.0 (see T57055)
Commits
rB5962db093f2f: Fix T97793, Fix T97795: Use correct defaults for missing values in new OBJ…
Summary
  • Fix T97793: when a UV coordinate after vt is missing, use zero. While at it, also use zeroes for positions & normals, since "maximum possible float" is very likely to cause issues in imported meshes.
  • Fix T97795: use 1.0 default if -bm value is missing, instead of zero.

Diff Detail

Repository
rB Blender

Event Timeline

Aras Pranckevicius (aras_p) requested review of this revision.May 3 2022, 12:46 PM
Aras Pranckevicius (aras_p) created this revision.
Howard Trickey (howardt) accepted this revision.May 3 2022, 1:19 PM

Makes sense. Thanks.

This revision is now accepted and ready to land.May 3 2022, 1:19 PM
Closed by commit rB5962db093f2f: Fix T97793, Fix T97795: Use correct defaults for missing values in new OBJ… (authored by Aras Pranckevicius (aras_p)). · Explain WhyMay 3 2022, 1:49 PM
This revision was automatically updated to reflect the committed changes.
Aras Pranckevicius (aras_p) added a commit: rB5962db093f2f: Fix T97793, Fix T97795: Use correct defaults for missing values in new OBJ….

Revision Contents
Changeset List

PathSize
source/
blender/
io/
wavefront_obj/
importer/
8 lines

Diff 51096

View Options

source/blender/io/wavefront_obj/importer/obj_import_file_reader.cc

Loading...