Page MenuHome
Differential D14829

GPencil: Apply layer transforms to visible frames
ClosedPublic
Actions

Authored by Yann Lanthony (yann-lty) on May 3 2022, 1:59 PM.

Details

Reviewers
Antonio Vazquez (antoniov)
Group Reviewers
Grease Pencil
Maniphest Tasks
T97799: Regression: Transforming a layer in GreasePencil doesn't transform Onion skin in >3.2
Commits
rBb31f5b8ce7ae: GPencil: Apply layer transforms to visible frames
Summary

Fix regression described in T97799.

Apply layer transform and layer parenting to all visible frames, i.e. active frame + onion skinning frames.

Diff Detail

Repository
rB Blender

Event Timeline

Yann Lanthony (yann-lty) requested review of this revision.May 3 2022, 1:59 PM
Yann Lanthony (yann-lty) created this revision.
Yann Lanthony (yann-lty) mentioned this in T97799: Regression: Transforming a layer in GreasePencil doesn't transform Onion skin in >3.2.May 3 2022, 2:07 PM
Falk David (filedescriptor) added a task: T97799: Regression: Transforming a layer in GreasePencil doesn't transform Onion skin in >3.2.May 3 2022, 2:40 PM
Falk David (filedescriptor) added a reviewer: Grease Pencil.May 3 2022, 3:10 PM
Antonio Vazquez (antoniov) accepted this revision.May 3 2022, 5:42 PM
Antonio Vazquez (antoniov) added a subscriber: Antonio Vazquez (antoniov).

Not tested but the code changes LGTM.

This revision is now accepted and ready to land.May 3 2022, 5:42 PM
Aleš Jelovčan (frogstomp) added a subscriber: Aleš Jelovčan (frogstomp).May 3 2022, 6:02 PM

tested, works as in 3.1.2

Antonio Vazquez (antoniov) added a subscriber: Falk David (filedescriptor).May 4 2022, 10:24 AM

@Falk David (filedescriptor) Can you commit the patch to close the high priority bug?

Closed by commit rBb31f5b8ce7ae: GPencil: Apply layer transforms to visible frames (authored by Yann Lanthony (yann-lty), committed by Falk David (filedescriptor)). · Explain WhyMay 4 2022, 12:59 PM
This revision was automatically updated to reflect the committed changes.
Falk David (filedescriptor) added a commit: rBb31f5b8ce7ae: GPencil: Apply layer transforms to visible frames.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
84 lines

Diff 51133

View Options

source/blender/blenkernel/intern/gpencil.c

Loading...