Previously, the extrapolation type's for an NLA action had no visual indicator. "Hold", "Hold Forward", and "Nothing" were visually indistinguishable.
Old:
New:
NLA's background now render's based on extrapolation type to give visual separation.
Details
Details
- Reviewers
Brad Clark (RiggingDojo) Sybren A. Stüvel (sybren) Colin Basnett (cmbasnett) - Maniphest Tasks
- T97572: NLA Action extrapolation display doesn't respond to the extrapolation settings always draws as if it was set to HOLD
- Commits
- rB2310daed3a55: NLA: draw track bg based on strip's extrapolation type
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- T97572 (branched from master)
- Build Status
Buildable 21950 Build 21950: arc lint + arc unit
Event Timeline
| source/blender/editors/space_nla/nla_draw.c | ||
|---|---|---|
| 801 | This seems a bit excessive to be doing every draw call. That function can run quite deep, and copying a potentially huge array just to discard it all and grab one value from it seems inefficient. Is there a less costly way to get the key range from an action? | |
| source/blender/editors/space_nla/nla_draw.c | ||
|---|---|---|
| 800 | This ED_keylist_create needs a corresponding ED_keylist_free, otherwise this will leak memory. | |
Comment Actions
Approved from the artist/animator side, this makes it very clear what the result will be when editing the extrapolation and what it is doing for new keys being created for the action when using the NLA in a layered animation workflow.
Comment Actions
LGTM, just one small change. Thanks @Colin Basnett (cmbasnett) for helping with the code review!
@Nate Rupsis (nrupsis) Could you replace the video in the description with a simple image, that shows the three extrapolation modes on three NLA tracks? That'll make a nicer one for the release notes/wiki.
| source/blender/editors/space_nla/nla_draw.c | ||
|---|---|---|
| 809 | Remove the default case. That way the compiler can issue a warning when another item in the enum is added. | |