Differential D14844

Proposed fix for T97851
ClosedPublic
Actions

Authored by Antonio Vazquez (antoniov) on May 4 2022, 4:46 PM.

Details

Reviewers

Aleš Jelovčan (frogstomp)

Maniphest Tasks

T97851: GPencil: "Bake object transform" operator wrong transformation of layer relations

Commits

rBb5c3885bf052: Fix T97851: GPencil Bake object transform operator wrong transformation

Summary

The problem was the layer transformation was already applied in the layer and if we apply in the bake, we are doing double transformation.

Diff Detail

Repository

rB Blender

Branch

temp-fix-T97851 (branched from master)

Build Status

Buildable 21965
Build 21965: arc lint + arc unit

Event Timeline

Antonio Vazquez (antoniov) requested review of this revision.May 4 2022, 4:46 PM

Antonio Vazquez (antoniov) created this revision.

Harbormaster completed remote builds in B21965: Diff 51150.May 4 2022, 4:46 PM

Antonio Vazquez (antoniov) added a task: T97851: GPencil: "Bake object transform" operator wrong transformation of layer relations.May 4 2022, 4:47 PM

Antonio Vazquez (antoniov) added a reviewer: Aleš Jelovčan (frogstomp).

Antonio Vazquez (antoniov) added a project: Grease Pencil.

Tested on 3.2 and master, both work perfectly, thanks for the fix

This revision is now accepted and ready to land.May 4 2022, 5:16 PM

Closed by commit rBb5c3885bf052: Fix T97851: GPencil Bake object transform operator wrong transformation (authored by Antonio Vazquez (antoniov)). · Explain WhyMay 4 2022, 5:19 PM

This revision was automatically updated to reflect the committed changes.

Antonio Vazquez (antoniov) added a commit: rBb5c3885bf052: Fix T97851: GPencil Bake object transform operator wrong transformation.

Aleš Jelovčan (frogstomp) mentioned this in T103234: Regression: Grease pencil: applying armature does not work. It is now similar to removing the armature modifier.Dec 15 2022, 9:07 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

gpencil/

gpencil_bake_animation.cc

5 lines

Diff 51150

View Options

source/blender/editors/gpencil/gpencil_bake_animation.cc

Proposed fix for T97851ClosedPublicActions