Fix T97853: Crash with edit mode X-ray and subdivision
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on May 5 2022, 11:00 AM.

Details

Reviewers

Germano Cavalcante (mano-wii)

Maniphest Tasks

T97853: Crash upon entering Edit Mode and toggling X-Ray

Commits

rBf9d7313bb7dd: Fix T97853: Crash with edit mode X-ray and subdivision
rB686abf185054: Fix T97853: Crash with edit mode X-ray and subdivision

Summary

The mesh drawing code used a different mesh to check whether or not to
draw face dots and to actually retrieve them. The fix is moving the
responsibility of determining whether to use subsurf face dots to the
creation of MeshRenderData where the mesh used for drawing is
known, rather than doing it at a higher level.

Diff Detail

Repository: rB Blender

Event Timeline

Hi @Germano Cavalcante (mano-wii), do you think this change is reasonable?

Hans Goudey (HooglyBoogly) added a task: T97853: Crash upon entering Edit Mode and toggling X-Ray.May 5 2022, 11:18 AM

Philipp Oeser (lichtwerk) added a project: EEVEE & Viewport.May 5 2022, 11:21 AM

Looks good to me.
I just wonder why we have this use_subsurf_fdots member.
It seems to me that we could just check if there is a mr->me->runtime.subsurf_face_dot_tags inside the extractors and always use that bitmap if it exists.

But that would be just to organize the code a bit more. (not relevant).

This revision is now accepted and ready to land.May 5 2022, 2:20 PM

Closed by commit rB686abf185054: Fix T97853: Crash with edit mode X-ray and subdivision (authored by Hans Goudey (HooglyBoogly)). · Explain WhyMay 9 2022, 5:37 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rB686abf185054: Fix T97853: Crash with edit mode X-ray and subdivision.

Hans Goudey (HooglyBoogly) added a commit: rBf9d7313bb7dd: Fix T97853: Crash with edit mode X-ray and subdivision.May 9 2022, 5:39 PM