Fix T97751: New OBJ IO - File Browser doesn't filter by .obj/.mtl
ClosedPublic
Actions

Authored by Julian Eisel (Severin) on May 5 2022, 4:24 PM.

Details

Reviewers

Aras Pranckevicius (aras_p)

Maniphest Tasks

T97751: New OBJ import: fileselector doesn't filter *.obj but shows all model-like files

Commits

rBaee8e4903146: Fix T97751: New OBJ IO - File Browser doesn't filter by .obj/.mtl
rBaae2ff49f5b8: Fix T97751: New OBJ IO - File Browser doesn't filter by .obj/.mtl

Summary

Makes the File Browser filter by .obj and .mtl files by default again. Note that this commit focuses on fixing this specific bug, further refactors/tweaks/fixes are planned (see D14863).

Diff Detail

Repository: rB Blender

Event Timeline

Julian Eisel (Severin) requested review of this revision.May 5 2022, 4:24 PM

Julian Eisel (Severin) created this revision.

Harbormaster completed remote builds in B21986: Diff 51199.May 5 2022, 4:24 PM

Philipp Oeser (lichtwerk) added a task: T97751: New OBJ import: fileselector doesn't filter *.obj but shows all model-like files.May 5 2022, 4:36 PM

Julian Eisel (Severin) edited the summary of this revision. (Show Details)May 5 2022, 4:53 PM

Julian Eisel (Severin) added a project: Pipeline, Assets & I/O.

Julian Eisel (Severin) mentioned this in D14863: IO: Refactor passing of IO file extension filters to the File Browser.

Julian Eisel (Severin) added inline comments.May 5 2022, 4:56 PM

source/blender/editors/io/io_obj.c
428	The reason for this change is not obvious - Basically this file filter and the `filter_glob` are OR'ed, so if the file is of any format covered by `FILE_TYPE_OBJECT_IO`, it will be shown. This is done in a better way in D14863.