Differential D14867

Win32: WM_SETTINGCHANGE lParam Check for NULL
ClosedPublic
Actions

Authored by Harley Acheson (harley) on May 6 2022, 12:17 AM.

Tags

Subscribers

None

Details

Reviewers

Ray Molenkamp (LazyDodo)
Jesse Yurkovich (deadpin)

Commits

rBfcbd81fb0f82: Win32: WM_SETTINGCHANGE lParam Check for NULL

Summary

Check that lParam is non-NULL in WM_SETTINGCHANGE message handler.

rBddbac88c08ef added a handler for WM_SETTINGCHANGE that does a string compare. Unfortunately it causes an access violation if lParam is NULL. According to Microsoft documentation "Note that some applications send this message with lParam set to NULL. This patch just adds a null check.

Diff Detail

Repository: rB Blender

Event Timeline

Harley Acheson (harley) requested review of this revision.May 6 2022, 12:17 AM

Harley Acheson (harley) created this revision.

Harley Acheson (harley) edited the summary of this revision. (Show Details)

Changed the comparison to be against NULL, not 0, since lParam is LONG_PTR

Jesse Yurkovich (deadpin) accepted this revision.May 6 2022, 12:33 AM

This revision is now accepted and ready to land.May 6 2022, 12:33 AM

Ray Molenkamp (LazyDodo) accepted this revision.May 6 2022, 1:13 AM

Closed by commit rBfcbd81fb0f82: Win32: WM_SETTINGCHANGE lParam Check for NULL (authored by Harley Acheson (harley)). · Explain WhyMay 6 2022, 2:49 AM

This revision was automatically updated to reflect the committed changes.

Harley Acheson (harley) added a commit: rBfcbd81fb0f82: Win32: WM_SETTINGCHANGE lParam Check for NULL.

Revision Contents
Changeset List

Path

Size

intern/

ghost/

intern/

GHOST_SystemWin32.cpp

3 lines

Diff 51213

intern/ghost/intern/GHOST_SystemWin32.cpp

Loading...