Page MenuHome
Differential D14891

Fix: compiler warnings due to recent patch
ClosedPublic
Actions

Authored by Ethan Hall (Ethan1080) on May 9 2022, 11:17 AM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Sergey Sharybin (sergey)
Commits
rB719c86c0a65d: Fix: compiler warnings due to recent commit
Summary

This is a fix for warnings caused by the patch D14724.

Diff Detail

Repository
rB Blender
Branch
fix_D14724_warnings (branched from master)
Build Status
Buildable 22023
Build 22023: arc lint + arc unit

Event Timeline

Ethan Hall (Ethan1080) requested review of this revision.May 9 2022, 11:17 AM
Ethan Hall (Ethan1080) created this revision.
Harbormaster completed remote builds in B22022: Diff 51285.May 9 2022, 11:17 AM
Sergey Sharybin (sergey) requested changes to this revision.May 9 2022, 11:26 AM
Sergey Sharybin (sergey) added a subscriber: Sergey Sharybin (sergey).
Sergey Sharybin (sergey) added inline comments.
source/blender/editors/sculpt_paint/paint_image_proj.c
6603
6610

The BLI_assert_unreachable is a no-op in release builds, which means release builds will still generate warning: variable 'new_node' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]

This revision now requires changes to proceed.May 9 2022, 11:26 AM
Jeroen Bakker (jbakker) added a subscriber: Jeroen Bakker (jbakker).May 9 2022, 11:27 AM
Jeroen Bakker (jbakker) added inline comments.
source/blender/editors/sculpt_paint/paint_image_proj.c
6609

Would not use default.
when adding new option, the compiler will poke the developer to think about the new option he added, default will hide this.

Ethan Hall (Ethan1080) added inline comments.May 9 2022, 11:34 AM
source/blender/editors/sculpt_paint/paint_image_proj.c
6603

oops

6610

I should return false after the assert.

Ethan Hall (Ethan1080) updated this revision to Diff 51286.May 9 2022, 11:45 AM
  • Tweak fixes
Harbormaster completed remote builds in B22023: Diff 51286.May 9 2022, 11:45 AM
Ethan Hall (Ethan1080) marked 3 inline comments as done.May 9 2022, 11:46 AM
Sergey Sharybin (sergey) accepted this revision.May 9 2022, 11:56 AM
This revision is now accepted and ready to land.May 9 2022, 11:56 AM
Hans Goudey (HooglyBoogly) accepted this revision.May 9 2022, 1:04 PM
Closed by commit rB719c86c0a65d: Fix: compiler warnings due to recent commit (authored by Ethan Hall (Ethan1080), committed by Hans Goudey (HooglyBoogly)). · Explain WhyMay 9 2022, 1:09 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rB719c86c0a65d: Fix: compiler warnings due to recent commit.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
sculpt_paint/
10 lines

Diff 51286

View Options

source/blender/editors/sculpt_paint/paint_image_proj.c

Loading...