Fix T97761: Incorrect mixing of integers.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on May 9 2022, 12:17 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Commits

rB2e70af5cd527: Fix T97761: incorrect mixing of integers

Summary

Not entirely sure if there are other places that need the same fix.

Diff Detail

Repository: rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.May 9 2022, 12:17 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B22024: Diff 51288.May 9 2022, 12:17 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)May 9 2022, 12:18 PM

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).

Hans Goudey (HooglyBoogly) accepted this revision.May 9 2022, 12:55 PM

Hans Goudey (HooglyBoogly) added inline comments.

source/blender/blenlib/BLI_math_base.hh
120–124	This could use a `std::round` too probably, to make negative numbers consistent.

This revision is now accepted and ready to land.May 9 2022, 12:55 PM

fix midpoint

Harbormaster completed remote builds in B22025: Diff 51289.May 9 2022, 1:01 PM

https://builder.blender.org/admin/#/builders/18/builds/398

Closed by commit rB2e70af5cd527: Fix T97761: incorrect mixing of integers (authored by Jacques Lucke (JacquesLucke)). · Explain WhyMay 18 2022, 5:03 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB2e70af5cd527: Fix T97761: incorrect mixing of integers.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

BKE_attribute_math.hh

12 lines

blenlib/

BLI_math_base.hh

12 lines

Diff 51602

View Options

source/blender/blenkernel/BKE_attribute_math.hh