Build: disable usage of GLEW, CLEW, CUDA, GLFW in OpenSubdiv
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on May 9 2022, 4:49 PM.

Details

Reviewers

Ray Molenkamp (LazyDodo)
Sybren A. Stüvel (sybren)

Commits

rBf4827d08bc9b: Build: disable usage of GLEW, CLEW, CUDA, GLFW in OpenSubdiv

Summary

The previous 3.1 libraries (accidentally) used glApi instead of GLEW and were
working for GPU subdivision, so revert to that. There's a suspected conflict
with Blender's own bundled GLEW or other issue with GLEW, causing the crash in
T97737.

The current GPU subdivision implementation does not need OpenCL, CUDA or GLFW.
So also remove libraries needed for that. It's simpler to stick to compute
shaders in OpenGL/Vulkan/Metal and not involve additional APIs.

Diff Detail

Repository

rB Blender

Branch

remove-glew (branched from master)

Build Status

Buildable 22030
Build 22030: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.May 9 2022, 4:49 PM

Brecht Van Lommel (brecht) created this revision.

Harbormaster completed remote builds in B22030: Diff 51298.May 9 2022, 4:49 PM

Sergey Sharybin (sergey) awarded a token.May 9 2022, 4:57 PM

While windows does not have issues, i'd still like all platforms to ship with identical flags, ie rebuild required for all platforms
I didn't have any build errors, so leaning towards accepting, however i'm stumped on testing..
Do we have a test file to validate OSD is still on the GPU when it needs to, so I can validate this actually doesn't break anything/puts things back on the CPU
This is going to both 3.2 and master correct?

I can confirm this fixes the problem (tested on @Pablo Fournier (pablico) 's computer).

In D14898#400629, @Ray Molenkamp (LazyDodo) wrote:

While windows does not have issues, i'd still like all platforms to ship with identical flags, ie rebuild required for all platforms

👍

Do we have a test file to validate OSD is still on the GPU when it needs to, so I can validate this actually doesn't break anything/puts things back on the CPU

Although I'm curious about this too, I'll simply accept & trust @Brecht Van Lommel (brecht) has a handle on this for Linux.