Page MenuHome
Differential D14903

LineArt: Use safe lineart_discard_duplicated_edges
ClosedPublic
Actions

Authored by YimingWu (NicksBest) on May 10 2022, 9:25 AM.

Details

Reviewers
Omar Emara (OmarSquircleArt)
Sebastian Parborg (zeddb)
Maniphest Tasks
T87739: Line Art further improvement list
T96781: Regression: Blender crash when using a particle system + grease pencil line art modifier
Commits
rB369f652c8046: LineArt: Use safe lineart_discard_duplicated_edges
Summary

The old method doesn't check e for array boundary.

The new method ensures it only access valid elements.

This should fix T96781, if so this should be backported to 3.2 as well.

Diff Detail

Repository
rB Blender

Event Timeline

YimingWu (NicksBest) requested review of this revision.May 10 2022, 9:25 AM
YimingWu (NicksBest) created this revision.
YimingWu (NicksBest) mentioned this in T96781: Regression: Blender crash when using a particle system + grease pencil line art modifier.
YimingWu (NicksBest) mentioned this in D14949: LineArt: Remove LineartEdge::obindex..May 16 2022, 7:14 AM
YimingWu (NicksBest) added a task: T87739: Line Art further improvement list.May 16 2022, 8:18 AM
Sebastian Parborg (zeddb) accepted this revision.May 17 2022, 4:39 PM
Sebastian Parborg (zeddb) added inline comments.
source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c
759

v1id and v2id is unused.

source/blender/makesdna/DNA_lineart_types.h
61

Grammar nitpick. I think the variable should be:
LRT_EDGE_FLAG_NEXT_IS_DUPLICATE

This revision is now accepted and ready to land.May 17 2022, 4:39 PM
Closed by commit rB369f652c8046: LineArt: Use safe lineart_discard_duplicated_edges (authored by YimingWu (NicksBest)). · Explain WhyMay 18 2022, 9:35 AM
This revision was automatically updated to reflect the committed changes.
YimingWu (NicksBest) added a commit: rB369f652c8046: LineArt: Use safe lineart_discard_duplicated_edges.
YimingWu (NicksBest) mentioned this in rB9f8254fd34ac: LineArt: Remove LineartEdge::obindex..

Revision Contents
Changeset List

PathSize
source/
blender/
gpencil_modifiers/
intern/
lineart/
13 lines
makesdna/
2 lines

Diff 51330

View Options

source/blender/gpencil_modifiers/intern/lineart/lineart_cpu.c

Loading...
View Options

source/blender/makesdna/DNA_lineart_types.h

Loading...