Page MenuHome

Fix for crash opening the file selector multiple times
ClosedPublic

Authored by Campbell Barton (campbellbarton) on May 10 2022, 10:13 AM.

Details

Summary

This is part of a fix for T88570, where the file selector would crash when activated multiple times.

Calling save multiple times would free the operator, leaving a dangling pointer which was used when panels were visible that accessed the "active_operator".


Noticed this when reviewing D13441, the steps to redo the crash are almost the same but it's a different bug.

To redo the crash with D13441 applied:

  • Open Blender with the factory settings.
  • Press Ctrl-S.
  • N (to show the side-bar).
  • Hold Ctrl-S, while doing so move the mouse between the root window and the file-selector.

Blender crashes P2930.

Diff Detail

Repository
rB Blender
Branch
TEMP-FIX-FILESEL-CRASH (branched from master)
Build Status
Buildable 22046
Build 22046: arc lint + arc unit

Event Timeline

Campbell Barton (campbellbarton) created this revision.
  • Only use the file-selector version of operator free for file-selector handlers.
This revision is now accepted and ready to land.May 10 2022, 12:09 PM

Dont we want this and D13441 in 3.2? (still crashes there).
This could even go into 2.93 LTS?

btw. this also fixed T95366: Crash when closing render window in "Save as".