Page MenuHome

Fix compiler warnings
ClosedPublic

Authored by Loren Osborn (linux_dr) on May 11 2022, 7:51 AM.

Details

Summary

These are fixes for the only three compiler warnings I encountered in my environment (macOS). I hope these are helpful.

This addresses the following warnings:

[ 50%] Building CXX object source/blender/io/alembic/CMakeFiles/bf_alembic.dir/exporter/abc_writer_hair.cc.o
/Users/linux_dr/blender-git/blender/source/blender/makesdna/intern/dna_defaults.c:190:1: warning: implicit conversion from 'int' to 'short' changes value from 53504 to -12032 [-Wconstant-conversion]
SDNA_DEFAULT_DECL_STRUCT(Mesh);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/linux_dr/blender-git/blender/source/blender/makesdna/intern/dna_defaults.c:139:56: note: expanded from macro 'SDNA_DEFAULT_DECL_STRUCT'
  static const struct_name DNA_DEFAULT_##struct_name = _DNA_DEFAULT_##struct_name
                                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~
<scratch space>:97:1: note: expanded from here
_DNA_DEFAULT_Mesh
^~~~~~~~~~~~~~~~~
/Users/linux_dr/blender-git/blender/source/blender/makesdna/DNA_mesh_defaults.h:25:112: note: expanded from macro '_DNA_DEFAULT_Mesh'
    .flag = ME_REMESH_REPROJECT_VOLUME | ME_REMESH_REPROJECT_PAINT_MASK | ME_REMESH_REPROJECT_SCULPT_FACE_SETS | ME_REMESH_REPROJECT_VERTEX_COLORS, \
            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 warning generated.

[ 88%] Building C object source/blender/modifiers/CMakeFiles/bf_modifiers.dir/intern/MOD_shapekey.c.o
/Users/linux_dr/blender-git/blender/source/blender/blenkernel/intern/curve_to_mesh_convert.cc:671:21: warning: suggest braces around initialization of subobject [-Wmissing-braces]
  Curves main_id = {nullptr};
                    ^~~~~~~
                    {      }
/Users/linux_dr/blender-git/blender/source/blender/blenkernel/intern/curve_to_mesh_convert.cc:676:24: warning: suggest braces around initialization of subobject [-Wmissing-braces]
  Curves profile_id = {nullptr};
                       ^~~~~~~
                       {      }

Diff Detail

Event Timeline

Loren Osborn (linux_dr) requested review of this revision.May 11 2022, 7:51 AM
Loren Osborn (linux_dr) created this revision.
Loren Osborn (linux_dr) edited the summary of this revision. (Show Details)May 11 2022, 5:26 PM

With my clean build, I just discovered the following new unaddressed warning:

(please hold this diff for additional fix.)

[ 62%] Building C object source/blender/makesrna/intern/CMakeFiles/bf_rna.dir/rna_curves_gen.c.o
In file included from /Users/linux_dr/blender-git/build_darwin/source/blender/makesrna/intern/rna_xr_gen.c:33:
/Users/linux_dr/blender-git/blender/source/blender/makesrna/intern/rna_xr.c:694:81: warning: unused parameter 'ptr' [-Wunused-parameter]
static int rna_XrSessionSettings_icon_from_show_object_viewport_get(PointerRNA *ptr)
                                                                                ^
[ 62%] Building C object source/blender/makesrna/intern/CMakeFiles/bf_rna.dir/rna_simulation_gen.c.o
1 warning generated.

This was added here: https://developer.blender.org/D14220#inline-127112
I need to conditionally put ptr inside a UNUSED() macro when WITH_XR_OPENXR isn't defined.

I'll change a few more places that read flag from short to uint16_t.

This revision is now accepted and ready to land.May 11 2022, 6:10 PM

I like the fix from https://developer.blender.org/rB309b6319a045ea95c7602475a4a5f5a6e4afdd07 better anyway. It's cleaner. can I just back out my update to the diff?

Diff has already landed and has been closed, if you just walk away from it all will be fine, if there's other changes you want to do, you'll have to make a new diff

Oh... cool... you merged it in before I even added my update (that I would have wanted to revert anyway!)... Not sure if that's great engineering and planning on someone else's part, or just dumb luck on my part. Ignore my latest unmerged changes