Page MenuHome
Differential D14928

Build: patch USD to avoid using rdtscp instruction not available on older CPUs
ClosedPublic
Actions

Authored by Brecht Van Lommel (brecht) on May 12 2022, 12:01 AM.

Details

Reviewers
Ray Molenkamp (LazyDodo)
Sybren A. Stüvel (sybren)
Maniphest Tasks
T97950: Crash on startup on older CPUs, due to unsupported instruction in USD libraries
Commits
rB018acc568893: Build: patch USD to avoid using rdtscp instruction not available on older CPUs
Summary

Disable the new more accurate timing code, this is not needed for Blender.
In USD itself this code is disabled on macOS anyway, so it should operate fine
without it.

Ref T97950

Diff Detail

Repository
rB Blender
Branch
blender-v3.2-release
Build Status
Buildable 22081
Build 22081: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested review of this revision.May 12 2022, 12:01 AM
Brecht Van Lommel (brecht) created this revision.
Harbormaster completed remote builds in B22081: Diff 51404.May 12 2022, 12:01 AM
Ray Molenkamp (LazyDodo) accepted this revision.May 12 2022, 4:09 AM

can confirm this allows blender to start with the Pentium 4 Prescott profile in intel's SDE

This revision is now accepted and ready to land.May 12 2022, 4:09 AM
Closed by commit rB018acc568893: Build: patch USD to avoid using rdtscp instruction not available on older CPUs (authored by Brecht Van Lommel (brecht)). · Explain WhyMay 12 2022, 6:39 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB018acc568893: Build: patch USD to avoid using rdtscp instruction not available on older CPUs.
Brecht Van Lommel (brecht) mentioned this in T95206: Libraries Changes for Blender 3.2.May 12 2022, 6:41 PM

We should commit updated libs for Windows and Linux, since they seem to be affected. macOS is not affected by this change.

Ray Molenkamp (LazyDodo) added a comment.May 12 2022, 6:43 PM

agree

Ray Molenkamp (LazyDodo) mentioned this in rBL62922: Windows: Updated USD 22.03.May 12 2022, 6:53 PM
Sybren A. Stüvel (sybren) mentioned this in rBL62925: Linux: Rebuilt USD 22.03.May 16 2022, 12:06 PM

Revision Contents
Changeset List

PathSize
build_files/
build_environment/
patches/
49 lines

Diff 51404

View Options

build_files/build_environment/patches/usd.diff

Loading...