Page MenuHome
Differential D14943

Cleanup: Improve const correctness of ID functions
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on May 13 2022, 4:48 PM.

Details

Reviewers
Bastien Montagne (mont29)
Commits
rBa40b61112831: Cleanup: Improve const correctness of ID functions
Summary

These functions don't change their inputs, so they can be const,
which is a bit more intuitive and clean to use for callers.

Originally I just wanted BKE_id_is_editable to have const inputs,
but it makes sense to change a few more similar functions too.

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.May 13 2022, 4:48 PM
Hans Goudey (HooglyBoogly) created this revision.
Hans Goudey (HooglyBoogly) updated this revision to Diff 52063.May 31 2022, 2:48 PM
  • Add mockup with C++ function override
Hans Goudey (HooglyBoogly) updated this revision to Diff 52076.May 31 2022, 4:40 PM
  • Add const casts as necessary
Hans Goudey (HooglyBoogly) added a child revision: D14934: Curves: Add float selection in sculpt mode.May 31 2022, 4:54 PM
Bastien Montagne (mont29) accepted this revision.May 31 2022, 5:17 PM

LGTM

This revision is now accepted and ready to land.May 31 2022, 5:17 PM
Closed by commit rBa40b61112831: Cleanup: Improve const correctness of ID functions (authored by Hans Goudey (HooglyBoogly)). · Explain WhyMay 31 2022, 5:31 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rBa40b61112831: Cleanup: Improve const correctness of ID functions.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
2 lines
4 lines
intern/
2 lines
31 lines

Diff 52081

View Options

source/blender/blenkernel/BKE_lib_id.h

Loading...
View Options

source/blender/blenkernel/BKE_lib_override.h

Loading...
View Options

source/blender/blenkernel/intern/lib_id.c

Loading...
View Options

source/blender/blenkernel/intern/lib_override.cc

Loading...