LineArt: Provide a intersection filtering master switch
AbandonedPublic
Actions

Authored by YimingWu (NicksBest) on May 16 2022, 7:07 AM.

Details

Reviewers

Sebastian Parborg (zeddb)
Aleš Jelovčan (frogstomp)

Maniphest Tasks

T87739: Line Art further improvement list

Summary

This extra checkbox allows user to filter "intersection with exact 0 masks".

The old behavior of intersection filtering is when no masks are selected then filtering is implicitly disabled. This may lead to confusions when using it, and makes it hard to select "the rest of the unmarked intersection". This option fixes that.

This option has been in temp-lineart-contained branch for a long time, I think I forgot to bring it to master.

Diff Detail

Repository: rB Blender

Event Timeline

YimingWu (NicksBest) requested review of this revision.May 16 2022, 7:07 AM

YimingWu (NicksBest) created this revision.

YimingWu (NicksBest) added a task: T87739: Line Art further improvement list.May 16 2022, 8:18 AM

Apparently there was a duplicated function in the patch. Fixed.

tested, getting errors:
rna_gpencil_modifier.c(3502,94): error C2065: 'LRT_GPENCIL_MATERIAL_MASK_ENABLE': : undeclared identifier
rna_gpencil_modifier.c(3508,93): error C2065: 'LRT_GPENCIL_MATERIAL_MASK_MATCH': undeclared identifier

Updated for fixing variable names.

CUSTOMBUILD : error (rna.define): rna_define.c:2208 rna_def_property_sdna: "EnvelopeGpencilModifierData.mask_switches" (identifier "use_intersection_filter") not found. Struct must be in DNA.
CUSTOMBUILD : error (rna.define): rna_define.c:2208 rna_def_property_sdna: "EnvelopeGpencilModifierData.mask_switches" (identifier "use_intersection_match") not found. Struct must be in DNA.

Should be okay now

builds, works as expected.

This revision is now accepted and ready to land.May 16 2022, 2:29 PM

The old behavior of intersection filtering is when no masks are selected then filtering is implicitly disabled. This may lead to confusions when using it, and makes it hard to select "the rest of the unmarked intersection". This option fixes that.

Isn't that what the exact match flag is for?

IE if no mask is selected, and exact match is off, then it will match everything.
But if exact match is on, it will only match the intersection flags exactly

After some discussions online we came to the conclusion that this change didn't bring much to the table as you could already do what this patch says it would fix/add.
So I'll close this.