Page MenuHome

LineArt: Prioritize connecting chains from the same contour loop
ClosedPublic

Authored by YimingWu (NicksBest) on May 16 2022, 7:29 AM.

Details

Summary

This change allows the chaining function to select edges from the same contour loop first, thus reduced rouge chain connections (connected different objects instead of chaining inside the same object first) and improved chaining quality.

This patch also included the default value change for chain split threshold (Now don't split by default to make initial result as smooth as possible). Maybe it can go into a separate commit? This value change is originally included with this feature as a intention of providing smoother "out of box" result, if needs to split I will then commit them as two separate patches.

This is also a feature that I forgot to put into master

Diff Detail

Repository
rB Blender

Event Timeline

YimingWu (NicksBest) requested review of this revision.May 16 2022, 7:29 AM
YimingWu (NicksBest) created this revision.

Besides my minor nitpick, LGTM.

source/blender/gpencil_modifiers/intern/lineart/lineart_chain.c
802

Just a few grammar nitpicks. I think it should be written like this:
Even if the vertex is not from the same contour loop, we try to chain it still if the distance is small enough. This way we can better chain smaller loops and smooth them out later.

This revision is now accepted and ready to land.May 17 2022, 3:57 PM
YimingWu (NicksBest) marked an inline comment as done.May 18 2022, 9:23 AM