Paths

Table of Contentst

Differential D14962

VSE: Improved Retiming system
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on May 16 2022, 8:23 PM.

Tags

None

Subscribers

None

Details

Reviewers

Francesco Siddi (fsiddi)

Summary

Patch implements better way to control playback speed than it is possible
to do with speed effect.

There are 2 layers of control:

Option to retime movie to match scene FPS rate.
Custom speed factor to control playback rate.

Since playback rate is strip property, it is now possible to manipulate
strip as normal one even if it is retimed.

To facilitate manipulation, some functions need to consider speed factor
and apply necessary corrections to strip offset or strip start. These
corrections may need to be float numbers, so start and offsets must be
float as well.

Sound strips now use speed factor instead of pitch. This means, that strips
will change length to match real length. In addition, it is possible to group
movie and sound strip and change speed of meta strip.

Diff Detail

Repository

Branch

retiming_2 (branched from master)

Build Status

Buildable 22451
Build 22451: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.May 16 2022, 8:23 PM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B22124: Diff 51547.May 16 2022, 8:23 PM

Richard Antalik (ISS) mentioned this in D14976: VSE: Remove still frame offsets.May 18 2022, 1:02 AM

Richard Antalik (ISS) mentioned this in rB8ca9ce09865e: VSE: Remove still frame offsets.May 18 2022, 9:45 PM

Rebase

Harbormaster completed remote builds in B22377: Diff 52142.Jun 2 2022, 3:50 AM

Fix issues after recent changes

Harbormaster completed remote builds in B22381: Diff 52150.Jun 2 2022, 5:15 AM

Fix issues after recent changes
Simplify offset handling

Harbormaster completed remote builds in B22419: Diff 52230.Jun 3 2022, 4:12 PM

Richard Antalik (ISS) edited the summary of this revision. (Show Details)Jun 3 2022, 4:14 PM

Fix xxx's
Make retiming to scene FPS optional

Harbormaster completed remote builds in B22435: Diff 52302.Jun 6 2022, 1:28 PM

Fix build error

Harbormaster completed remote builds in B22448: Diff 52339.Jun 7 2022, 2:22 PM

Fix one more build error

Harbormaster completed remote builds in B22449: Diff 52342.Jun 7 2022, 2:41 PM

Fix more build errors..

Harbormaster completed remote builds in B22450: Diff 52345.Jun 7 2022, 3:17 PM

Fix more build errors..

Harbormaster completed remote builds in B22451: Diff 52346.Jun 7 2022, 3:33 PM

Rebase, fix crash when transforming

Harbormaster completed remote builds in B22733: Diff 52996.Jun 28 2022, 2:12 PM

Fix drawing glitch

Harbormaster completed remote builds in B22735: Diff 52998.Jun 28 2022, 2:43 PM

Bit of cleanup, use speed factor for sound too.
Apply meta strip speed to sound strips
Supply scene to seq_cmp_time_startdisp_channel function

Harbormaster completed remote builds in B22751: Diff 53027.Jun 28 2022, 9:05 PM

Copy sound pitch into speed factor
Remove strip pitch property, only speed factor is used in code.

Harbormaster completed remote builds in B22752: Diff 53029.Jun 28 2022, 9:20 PM

Richard Antalik (ISS) retitled this revision from [WIP] VSE retiming to VSE: Improved Retiming system.Jun 28 2022, 9:27 PM

Richard Antalik (ISS) edited the summary of this revision. (Show Details)

Richard Antalik (ISS) added a reviewer: Francesco Siddi (fsiddi).

Cleanup

Harbormaster completed remote builds in B22753: Diff 53031.Jun 28 2022, 9:40 PM

Francesco Siddi (fsiddi) accepted this revision.Jun 29 2022, 10:23 AM

This revision is now accepted and ready to land.Jun 29 2022, 10:23 AM

Closed by rB302b04a5a3fc0e767ac784424f78ce2edf5d2844
Forgot to link diff to commit.

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

bl_ui/

space_sequencer.py

4 lines

source/

blender/

blenkernel/

intern/

12 lines

blenloader/

intern/

versioning_290.c

17 lines

versioning_300.c

16 lines

editors/

animation/

4 lines

space_sequencer/

sequencer_add.c

51 lines

sequencer_channels_draw.c

2 lines

sequencer_drag_drop.c

4 lines

sequencer_draw.c

188 lines

sequencer_edit.c

155 lines

sequencer_intern.h

6 lines

sequencer_select.c

139 lines

sequencer_thumbnails.c

47 lines

sequencer_view.c

6 lines

space_sequencer.c

5 lines

transform/

transform_convert_sequencer.c

139 lines

transform_convert_sequencer_image.c

3 lines

transform_gizmo_2d.c

11 lines

transform_snap_sequencer.c

37 lines

makesdna/

DNA_sequence_types.h

13 lines

makesrna/

intern/

rna_sequencer.c

65 lines

rna_sequencer_api.c

18 lines

sequencer/

6 lines

5 lines

5 lines

16 lines

13 lines

24 lines

SEQ_transform.h

16 lines

intern/

4 lines

44 lines

34 lines

37 lines

2 lines

29 lines

3 lines

65 lines

2 lines

4 lines

21 lines

140 lines

strip_relations.c

26 lines

4 lines

195 lines

strip_transform.c

123 lines

5 lines

Diff 52346

release/scripts/startup/bl_ui/space_sequencer.py

Loading...

source/blender/blenkernel/intern/sound.c

Loading...

source/blender/blenloader/intern/versioning_290.c

Loading...

source/blender/blenloader/intern/versioning_300.c

Loading...

source/blender/editors/animation/anim_ops.c

Loading...

source/blender/editors/space_sequencer/sequencer_add.c

Loading...

source/blender/editors/space_sequencer/sequencer_channels_draw.c

Loading...

source/blender/editors/space_sequencer/sequencer_drag_drop.c

Loading...

source/blender/editors/space_sequencer/sequencer_draw.c

Loading...

source/blender/editors/space_sequencer/sequencer_edit.c

Loading...

source/blender/editors/space_sequencer/sequencer_intern.h

Loading...

source/blender/editors/space_sequencer/sequencer_select.c

Loading...

source/blender/editors/space_sequencer/sequencer_thumbnails.c

Loading...

source/blender/editors/space_sequencer/sequencer_view.c

Loading...

source/blender/editors/space_sequencer/space_sequencer.c

Loading...

source/blender/editors/transform/transform_convert_sequencer.c

Loading...

source/blender/editors/transform/transform_convert_sequencer_image.c

Loading...

source/blender/editors/transform/transform_gizmo_2d.c

Loading...

source/blender/editors/transform/transform_snap_sequencer.c

Loading...

source/blender/makesdna/DNA_sequence_types.h

Loading...

source/blender/makesrna/intern/rna_sequencer.c

Loading...

source/blender/makesrna/intern/rna_sequencer_api.c

Loading...

source/blender/sequencer/SEQ_add.h

Loading...

source/blender/sequencer/SEQ_edit.h

Loading...

source/blender/sequencer/SEQ_effects.h

Loading...

source/blender/sequencer/SEQ_iterator.h

Loading...

source/blender/sequencer/SEQ_render.h

Loading...

source/blender/sequencer/SEQ_time.h

Loading...

source/blender/sequencer/SEQ_transform.h

Loading...

source/blender/sequencer/intern/disk_cache.c

Loading...

source/blender/sequencer/intern/effects.c

Loading...

source/blender/sequencer/intern/image_cache.c

Loading...

source/blender/sequencer/intern/iterator.c

Loading...

source/blender/sequencer/intern/prefetch.c

Loading...

source/blender/sequencer/intern/proxy.c

Loading...

source/blender/sequencer/intern/render.h

Loading...

source/blender/sequencer/intern/render.c

Loading...

source/blender/sequencer/intern/sequencer.c

Loading...

source/blender/sequencer/intern/sound.c

Loading...

source/blender/sequencer/intern/strip_add.c

Loading...

source/blender/sequencer/intern/strip_edit.c

Loading...

source/blender/sequencer/intern/strip_relations.c

Loading...

source/blender/sequencer/intern/strip_time.h

Loading...

source/blender/sequencer/intern/strip_time.c

Loading...

source/blender/sequencer/intern/strip_transform.c

Loading...

source/blender/sequencer/intern/utils.c

Loading...