Paths

Table of Contentst

remove action edited tab from NLA strip select
ClosedPublic
Actions

Authored by Nate Rupsis (nrupsis) on May 17 2022, 1:28 AM.

Details

Reviewers

Sybren A. Stüvel (sybren)
Brad Clark (RiggingDojo)

Commits

rBb6ebd5591c7f: NLA: Remove Edited Action tab from NLA panel

Summary

This patch removes the "Edited Action" tab for selected Action strips in the NLA editor

Old:

New:

Diff Detail

Repository: rB Blender

Event Timeline

Nate Rupsis (nrupsis) requested review of this revision.May 17 2022, 1:28 AM

Nate Rupsis (nrupsis) created this revision.

Harbormaster completed remote builds in B22126: Diff 51550.May 17 2022, 1:28 AM

Nate Rupsis (nrupsis) edited the summary of this revision. (Show Details)May 17 2022, 1:40 AM

Nate Rupsis (nrupsis) added a project: Animation & Rigging.

Yeah having it removed I think is the right thing, the way I am seeing it work in the video feels good an removes the risk of mistakes of ending up on the wrong tab and trying to fix things that are not strip related.
Approved from the artist side of things.

This revision is now accepted and ready to land.May 17 2022, 4:21 AM

So. Much. Better this way.

Just a few inline notes, which don't need any reuploading of the patch. One thing I'm curious about is the parentheses thing. Do you prefer

return (nla_panel_context(C, &ptr, NULL, &strip_ptr) && (ptr.data != NULL) && (ptr.owner_id != strip_ptr.owner_id));

return nla_panel_context(C, &ptr, NULL, &strip_ptr) && ptr.data != NULL && ptr.owner_id != strip_ptr.owner_id;

source/blender/editors/space_nla/nla_buttons.c
217	I'm not a fan of superfluous parentheses, so if you want, feel free to be inconsistent with the previous expression and remove them: return nla_panel_context(C, &ptr, NULL, &strip_ptr) && ptr.data != NULL && ptr.owner_id != strip_ptr.owner_id;
280	Make sure you either have Clang-Format set up in your IDE or run `make format` before submitting patches. No need to resubmit though, I'll run `make format` before landing the patch.

Philipp Oeser (lichtwerk) awarded a token.May 17 2022, 11:54 AM

In D14964#402593, @Sybren A. Stüvel (sybren) wrote:
So. Much. Better this way.

Just a few inline notes, which don't need any reuploading of the patch. One thing I'm curious about is the parentheses thing. Do you prefer
return (nla_panel_context(C, &ptr, NULL, &strip_ptr) && (ptr.data != NULL) && (ptr.owner_id != strip_ptr.owner_id));
or
return nla_panel_context(C, &ptr, NULL, &strip_ptr) && ptr.data != NULL && ptr.owner_id != strip_ptr.owner_id;
?

my preference has always been to be as explicit as possible when it comes to mathematical (or logical) operations. hence the groupings for parentheses (i swear i don't come from a lisp background 😄 )

But at the end of the day, It doesn't really matter to me, and I'd rather follow conventions that others prefer.

Looks like my auto-format wasn't on for my Vscode workspace 🙄 That should be fixed.

Closed by commit rBb6ebd5591c7f: NLA: Remove Edited Action tab from NLA panel (authored by Nate Rupsis (nrupsis), committed by Sybren A. Stüvel (sybren)). · Explain WhySep 13 2022, 3:11 PM

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) added a commit: rBb6ebd5591c7f: NLA: Remove Edited Action tab from NLA panel.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_nla/

nla_buttons.c

10 lines

Diff 55626

View Options

source/blender/editors/space_nla/nla_buttons.c

remove action edited tab from NLA strip selectClosedPublicActions