Page MenuHome

VSE: Remove still frame offsets
ClosedPublic

Authored by Richard Antalik (ISS) on May 18 2022, 1:02 AM.

Details

Summary

To clarify term still frame: This is portion of strip that displays
static image. This area can exist before or after strip movie content.

Still frames were implemented as strip property, but this was never
displayed in panel. Only way to set still frames was to drag strip
handle with mouse or using python API. This would set either
seq->*still or seq->*ofs where * stands for start or end.

When strip had offset, it can't have still frames and vice versa, but
this had to be enforced in RNA functions and everywhere in code where
these fields are set directly. Strip can not have negative offset or
negative number of still frames.

This is not very practical approach and still frames can be simply
implemented as applying negative offset. Merging these offsets would
simplify offset calculations for example in D14962 and could make it
easier to also deprecate usage seq->*disp and necessity to call
update functions to recalculate strip boundaries.

For users only functional change is ability to set negative strip offset
using property in side panel.

Diff Detail

Repository
rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.May 18 2022, 1:02 AM
Richard Antalik (ISS) created this revision.

Does this change get in a way of supporting still frame around a strip cut?

Does this change get in a way of supporting still frame around a strip cut?

No, this is supported currently and this patch does not change this functionally. for potential future tools, this would neither complicate things, IMO tool could do "hold cut" and move handle if with 2 functions that are designed to do this already.

If there is no restrictions on artists, and no complications for the future planned work go ahead with the change.

This revision is now accepted and ready to land.May 18 2022, 3:50 PM
This revision was automatically updated to reflect the committed changes.