Details

Reviewers

Maniphest Tasks

T90182: Slider Widget for blending poses

Commits

rB2522ca03d206: Asset Browser: Add slider UI to pose blending

Summary

Adds Slider UI implemented in ED_util.h to pose blending. This
adds a slider with percentages, and controls for precision
control and incremental control.

Current uncertainty is where to show the slider. ATM, it displays in
the asset browser header when using it from there, or in the
3D view header when using the poses in the animation N-panel.

Demos:

From Asset Library

From Pose Library

Diff Detail

Repository

rB Blender

Branch

T90182-blend-pose-slider (branched from master)

Build Status

Buildable 22161
Build 22161: arc lint + arc unit

Event Timeline

Angus Stanton (abstanton) requested review of this revision.May 19 2022, 12:13 PM

Angus Stanton (abstanton) created this revision.

Angus Stanton (abstanton) retitled this revision from T90182: Asset Browser: Add slider UI to pose blending to Asset Browser: Add slider UI to pose blending.May 19 2022, 12:13 PM

Harbormaster completed remote builds in B22161: Diff 51613.May 19 2022, 12:13 PM

Angus Stanton (abstanton) added a reviewer: Sybren A. Stüvel (sybren).May 19 2022, 12:15 PM

Angus Stanton (abstanton) edited the summary of this revision. (Show Details)

Ramil Roosileht (Limarest) mentioned this in D15137: Try to introduce a slider widget for sculpt mesh filter.Jun 7 2022, 10:01 PM

Angus Stanton (abstanton) edited the summary of this revision. (Show Details)Jun 20 2022, 11:54 AM

Thanks for the patch! This is something we had in mind for a long time, and never got the change to actually implement :)

The only thing that's not going well yet is that the blending now starts at 50%. This means that there is always a visual "jerk", instead of smoothly blending the asset pose into the current pose. Here you can see what I mean:

For a future patch, it would be sweet if animators could also type in the blend percentage. I think this is also possible with the tSlider approach, so shouldn't be too tricky to get working. That's not necessary for this patch, though, as with the current implementation that's also not possible.

source/blender/editors/armature/pose_lib_2.c
201	The execution order is pretty clear from the source code, as it's just top-to-bottom. Personally I'd only add a "First" if there is a concrete need to explain why this code has to be executed first (sometimes such things can be hard to understand, and then a comment helps). In this case I'd just remove the "First" though.
482	No need to have this comment here, it's clear what the code does.

This revision now requires changes to proceed.Jun 20 2022, 3:53 PM

Merge branch 'master' into T90182-blend-pose-slider
Start blend at 0%

Harbormaster completed remote builds in B22635: Diff 52781.Jun 22 2022, 1:56 PM

Remove comments as per diff review

Harbormaster completed remote builds in B22636: Diff 52782.Jun 22 2022, 1:59 PM

Angus Stanton (abstanton) marked 2 inline comments as done.Jun 22 2022, 2:00 PM

Sybren A. Stüvel (sybren) requested changes to this revision.Jun 23 2022, 2:25 PM

Sybren A. Stüvel (sybren) added inline comments.

source/blender/editors/armature/pose_lib_2.c
340	This will cause a crash when `event` is `NULL`, which happens when applying a pose, instead of blending one. The slider should only be created when blending, and not when applying a pose. Other slider-related code should only run when `pbd->slider != NULL`.

This revision now requires changes to proceed.Jun 23 2022, 2:25 PM

Fix breaking of apply pose OT

Only initialise slider if event==NULL
Move blend op text help to modal func

Harbormaster completed remote builds in B22658: Diff 52828.Jun 23 2022, 3:33 PM

Angus Stanton (abstanton) marked an inline comment as done.Jun 23 2022, 3:35 PM

Angus Stanton (abstanton) added inline comments.

source/blender/editors/armature/pose_lib_2.c
340	I haven't checked for null in the modal or handle event functions since they don't run when using pose apply (unless I'm being silly)

Angus Stanton (abstanton) marked an inline comment as done.Jun 28 2022, 11:17 AM

Christoph Lendenfeld (ChrisLend) awarded a token.Jul 3 2022, 5:49 PM

Luciano Muñoz Sessarego (looch) awarded a token.Jul 28 2022, 7:13 PM

Luciano Muñoz Sessarego (looch) rescinded a token.

Luciano Muñoz Sessarego (looch) awarded a token.

Luciano Muñoz Sessarego (looch) added a subscriber: Luciano Muñoz Sessarego (looch).

An alternative approach could be to copy the timeline widget(or something similar) into the preview:

This way, all assets with a time element can be searched or even have in or
in&out points set before being added to the scene.

In D14984#425553, @Peter Fog (tintwotin) wrote:

This way, all assets with a time element can be searched or even have in or
in&out points set before being added to the scene.

Not sure if this makes sense for this use case, since the pose assets don't have a time element. The slider is for interpolating between the current pose and the pose asset, not for playing through an animation asset.

Joseph Brandenburg (TheAngerSpecialist) awarded a token.Sep 24 2022, 10:04 PM

Bump

Thanks for the poke, because this should really land :)

This patch is great, not just from a UI perspective but also the removal of all the now-unnecessary code. Much cleaner this way!

This revision is now accepted and ready to land.Sep 26 2022, 4:17 PM

Sybren A. Stüvel (sybren) added projects: BF Blender, Animation & Rigging.Sep 26 2022, 4:17 PM

Closed by commit rB2522ca03d206: Asset Browser: Add slider UI to pose blending (authored by Angus Stanton (abstanton), committed by Sybren A. Stüvel (sybren)). · Explain WhySep 26 2022, 4:21 PM

This revision was automatically updated to reflect the committed changes.

Sybren A. Stüvel (sybren) added a commit: rB2522ca03d206: Asset Browser: Add slider UI to pose blending.

Juan Gabriel (Juangra_Membata) awarded a token.Sep 26 2022, 4:45 PM

Brad Clark (RiggingDojo) added a subscriber: Brad Clark (RiggingDojo).Sep 27 2022, 5:11 PM

Paul Larson (GeorgiaPacific) added a subscriber: Paul Larson (GeorgiaPacific).Oct 3 2022, 6:33 PM