Differential D15005

GPencil: Fix simplify->sample behavior
ClosedPublic
Actions

Authored by YimingWu (NicksBest) on May 21 2022, 3:12 PM.

Tags

Subscribers

None

Tokens

"Like" token, awarded by hitrpr.

Details

Reviewers

Aleš Jelovčan (frogstomp)
Antonio Vazquez (antoniov)

Maniphest Tasks

T98258: GPencil: Double vertices after simplify with short sample length

Commits

rB3fe1079ecfb4: Fix T98258: Duplicated last vertex after GPencil sample.
rBc4e5a7d59a06: Fix T98258: Duplicated last vertex after GPencil sample.

Summary

This patch fixed the problem where in simplify modifier sample mode it will sometimes generate duplicated vertices in the end of the stroke.

Also fixed a interpolation ration bug (unreported).

Diff Detail

Repository: rB Blender

Event Timeline

YimingWu (NicksBest) requested review of this revision.May 21 2022, 3:12 PM

YimingWu (NicksBest) created this revision.

YimingWu (NicksBest) added a task: T98258: GPencil: Double vertices after simplify with short sample length.

YimingWu (NicksBest) mentioned this in T98258: GPencil: Double vertices after simplify with short sample length.

Fix optimizer flag.

works perfectly, thanks!

This revision is now accepted and ready to land.May 21 2022, 3:43 PM

LGTM

Vyacheslav (hitrpr) awarded a token.May 23 2022, 8:44 AM

Closed by commit rBc4e5a7d59a06: Fix T98258: Duplicated last vertex after GPencil sample. (authored by YimingWu (NicksBest)). · Explain WhyMay 23 2022, 10:19 AM

This revision was automatically updated to reflect the committed changes.

YimingWu (NicksBest) added a commit: rBc4e5a7d59a06: Fix T98258: Duplicated last vertex after GPencil sample..

Bastien Montagne (mont29) added a commit: rB3fe1079ecfb4: Fix T98258: Duplicated last vertex after GPencil sample..May 23 2022, 12:14 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

gpencil_geom.cc

33 lines

Diff 51705

source/blender/blenkernel/intern/gpencil_geom.cc

Loading...