Page MenuHome
Differential D15011

Cleanup: Simplify custom data file writing process
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on May 22 2022, 8:49 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Commits
rB3152d68b7006: Cleanup: Simplify custom data file writing process
Summary

Previously the function had a fair amount of ugly boilerplate to avoid
allocating the temporary layers array, and then free it if necessary.
blender::Vector solves that problem more elegantly. Passing a span,
using references in a few cases, and using a switch statement also make
the functions simpler.

This refactoring is in preparation for D14583 and D14685.

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.May 22 2022, 8:49 PM
Hans Goudey (HooglyBoogly) created this revision.
Hans Goudey (HooglyBoogly) added a child revision: D14077: Refactor: Move bevel weight out of MVert and MEdge.May 22 2022, 9:02 PM
Hans Goudey (HooglyBoogly) added a child revision: D14685: Refactor: Move mesh hide flags to generic attributes.
Jacques Lucke (JacquesLucke) accepted this revision.May 23 2022, 12:44 PM
Jacques Lucke (JacquesLucke) added inline comments.
source/blender/blenkernel/BKE_customdata.h
716

typo (invalidating)

This revision is now accepted and ready to land.May 23 2022, 12:44 PM
Closed by commit rB3152d68b7006: Cleanup: Simplify custom data file writing process (authored by Hans Goudey (HooglyBoogly)). · Explain WhyMay 29 2022, 11:02 AM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rB3152d68b7006: Cleanup: Simplify custom data file writing process.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
44 lines
intern/
24 lines
141 lines
52 lines
20 lines
makesdna/
2 lines

Diff 51965

View Options

source/blender/blenkernel/BKE_customdata.h

Loading...
View Options

source/blender/blenkernel/intern/curves.cc

Loading...
View Options

source/blender/blenkernel/intern/customdata.cc

Loading...
View Options

source/blender/blenkernel/intern/mesh.cc

Loading...
View Options

source/blender/blenkernel/intern/pointcloud.cc

Loading...
View Options

source/blender/makesdna/DNA_customdata_types.h

Loading...