Page MenuHome
Differential D15018

Geometry Node: Capture Attribute: Skip if attribute not needed
ClosedPublic
Actions

Authored by Iliya Katueshenock (Moder) on May 24 2022, 3:58 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Commits
rBc980ed27f09f: Geometry Nodes: skip Capture Attribute node if output is not needed
Summary

Now, if the attribute is not needed (for example, a switch), the
node still executes the logic for calculating the attribute data T96109.
This patch should add the option:

  • If the geometry is not requested
  • If the attribute is not requested

Both of these options do not require calculations.

Diff Detail

Event Timeline

Iliya Katueshenock (Moder) requested review of this revision.May 24 2022, 3:58 PM
Iliya Katueshenock (Moder) planned changes to this revision.
Iliya Katueshenock (Moder) created this revision.

Upgrading to master status to fix unrelated changes

Iliya Katueshenock (Moder) updated this revision to Diff 51795.May 24 2022, 4:06 PM

Upgrading to master, fixing unrelated changes

Iliya Katueshenock (Moder) edited the summary of this revision. (Show Details)May 24 2022, 4:06 PM
Iliya Katueshenock (Moder) edited the summary of this revision. (Show Details)
Iliya Katueshenock (Moder) updated this revision to Diff 51797.May 24 2022, 4:10 PM

Name change

Iliya Katueshenock (Moder) updated this revision to Diff 51798.May 24 2022, 4:25 PM

Now there is an error for the attribute, and also moved the type comparison to the function

Iliya Katueshenock (Moder) added a comment.May 24 2022, 4:28 PM

Iliya Katueshenock (Moder) edited the summary of this revision. (Show Details)May 24 2022, 4:30 PM
Jacques Lucke (JacquesLucke) requested changes to this revision.May 24 2022, 4:38 PM
Jacques Lucke (JacquesLucke) added a subscriber: Jacques Lucke (JacquesLucke).
Jacques Lucke (JacquesLucke) added inline comments.
source/blender/nodes/geometry/nodes/node_geo_attribute_capture.cc
129

Since you added this now, it should also be used for the other inputs and outputs. (define a input_identifier and output_identifier variable outside of the switch statements)

138

An info like The attribute output can not be used without the geometry output would probably be more useful.

144

This does not require an info message.

This revision now requires changes to proceed.May 24 2022, 4:38 PM
Iliya Katueshenock (Moder) updated this revision to Diff 51799.May 24 2022, 5:02 PM
Iliya Katueshenock (Moder) marked 3 inline comments as done.

Fixes

Jacques Lucke (JacquesLucke) added inline comments.May 24 2022, 5:31 PM
source/blender/nodes/geometry/nodes/node_geo_attribute_capture.cc
137

This has to be a std::string, otherwise it's a memory error, same below.
That's because a StringRef can only reference memory that's owned by someone else.

Iliya Katueshenock (Moder) updated this revision to Diff 51802.May 24 2022, 5:39 PM
Iliya Katueshenock (Moder) marked an inline comment as done.

Correction of string memory ownership

Jacques Lucke (JacquesLucke) accepted this revision.May 25 2022, 1:54 PM
This revision is now accepted and ready to land.May 25 2022, 1:54 PM
Closed by commit rBc980ed27f09f: Geometry Nodes: skip Capture Attribute node if output is not needed (authored by • YURY (MOD), committed by Jacques Lucke (JacquesLucke)). · Explain WhyMay 25 2022, 1:58 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rBc980ed27f09f: Geometry Nodes: skip Capture Attribute node if output is not needed.
Jacques Lucke (JacquesLucke) added a comment.May 25 2022, 2:04 PM

Note, the commit is currently attributed to someone else on phabricator, that's not the case in git though. Phabricator is a bit weird in that regard sometimes, happens every now and then... Sorry about that. Maybe it can be fixed, but hopefully we can move to another platform that doesn't have the same problem soonish.

Iliya Katueshenock (Moder) mentioned this in T96109: Geometry Node: Recursive field re-evaluation.May 25 2022, 5:53 PM
Vyacheslav (hitrpr) awarded a token.Jun 23 2022, 9:12 PM

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
38 lines

Diff 51797

View Options

source/blender/nodes/geometry/nodes/node_geo_attribute_capture.cc

Loading...