Fix T98403: Crash applying modifiers on non-mesh objects
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on May 30 2022, 4:15 PM.

Details

Reviewers

Campbell Barton (campbellbarton)

Maniphest Tasks

T98403: Mesh to Volume and Volume Displace modifiers crash with the new Hair Curve when pressing apply

Commits

rB18a17d42911d: Fix T98403: Crash applying modifiers on non-mesh objects

Summary

The operator assumed it was called on a mesh object, which has
mostly been the case because of lack of support for other object
types, but the new curves object is supported, which is the situation
in the report.

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.May 30 2022, 4:15 PM

Hans Goudey (HooglyBoogly) created this revision.

Hans Goudey (HooglyBoogly) added a task: T98403: Mesh to Volume and Volume Displace modifiers crash with the new Hair Curve when pressing apply.

Campbell Barton (campbellbarton) accepted this revision.May 31 2022, 9:31 AM

Campbell Barton (campbellbarton) added inline comments.

source/blender/editors/object/object_modifier.cc
1471	This check should be added to `modifier_convert_exec` too.

This revision is now accepted and ready to land.May 31 2022, 9:31 AM

Campbell Barton (campbellbarton) added inline comments.May 31 2022, 9:35 AM

source/blender/editors/object/object_modifier.cc
1471	Edit checking on `modifier_convert_exec` it seems this should not have had `BKE_mesh_merge_customdata_for_apply_modifier` added in the first place. So I think this patch is fine as-is.