Page MenuHome
Differential D15071

Fix T98500: Wrong selection in Duplicate Points
ClosedPublic
Actions

Authored by Johnny Matthews (guitargeek) on May 30 2022, 8:37 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T98500: Geometry Nodes, Duplicate Elements, Selection chooses the wrong elements
Commits
rB52cb24a7796c: Fix T98500: Wrong Selection in Duplicate Points
Summary

Wasn't passing the selection deep enough into the copy functions. This seems like a change that will need some testing that it doesn't screw things up.

T98500

Diff Detail

Repository
rB Blender
Branch
fix_selection (branched from master)
Build Status
Buildable 22331
Build 22331: arc lint + arc unit

Event Timeline

Johnny Matthews (guitargeek) requested review of this revision.May 30 2022, 8:37 PM
Johnny Matthews (guitargeek) created this revision.
Harbormaster completed remote builds in B22331: Diff 52023.May 30 2022, 8:37 PM
Johnny Matthews (guitargeek) edited the summary of this revision. (Show Details)May 30 2022, 9:19 PM
Hans Goudey (HooglyBoogly) accepted this revision.May 30 2022, 9:21 PM
Hans Goudey (HooglyBoogly) added a task: T98500: Geometry Nodes, Duplicate Elements, Selection chooses the wrong elements.

This looks correct to me. Easy to miss something like this when there are so many cases to test.

source/blender/nodes/geometry/nodes/node_geo_duplicate_elements.cc
100

Might it make sense to assert that selection.size() == offsets.size()?

This revision is now accepted and ready to land.May 30 2022, 9:22 PM
Johnny Matthews (guitargeek) updated this revision to Diff 52028.May 30 2022, 10:39 PM

Change to commit against 3.2 master

Harbormaster completed remote builds in B22334: Diff 52028.May 30 2022, 10:39 PM
Hans Goudey (HooglyBoogly) added inline comments.May 31 2022, 10:07 AM
source/blender/nodes/geometry/nodes/node_geo_duplicate_elements.cc
361–389

In the 3.2 branch we should probably avoid doing this renaming

Johnny Matthews (guitargeek) updated this revision to Diff 52074.May 31 2022, 4:27 PM
Johnny Matthews (guitargeek) marked 2 inline comments as done.
  • put variable names back to 3.2 versions
Harbormaster completed remote builds in B22354: Diff 52074.May 31 2022, 4:27 PM
Hans Goudey (HooglyBoogly) accepted this revision.May 31 2022, 4:43 PM
Closed by commit rB52cb24a7796c: Fix T98500: Wrong Selection in Duplicate Points (authored by Johnny Matthews (guitargeek)). · Explain WhyMay 31 2022, 5:12 PM
This revision was automatically updated to reflect the committed changes.
Johnny Matthews (guitargeek) added a commit: rB52cb24a7796c: Fix T98500: Wrong Selection in Duplicate Points.

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
52 lines

Diff 52023

View Options

source/blender/nodes/geometry/nodes/node_geo_duplicate_elements.cc

Loading...