Cleanup: Remove unused sculpt and vertex color operators
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on May 31 2022, 10:03 AM.

Details

Reviewers

Brecht Van Lommel (brecht)
Joseph Eagar (joeedh)

Commits

rB44aa9e40ffe4: Cleanup: Remove unused sculpt and vertex color operators

Summary

The "Color Attributes" system from f7bbc7cdbb6cb0d2850 has replaced
both "Sculpt Vertex Colors" and "Vertex Colors" in the UI. The Operators
for adding and removing them are unused now.

This commit does not break backwards compatibility with the Python
API, it only removes the operators, which generally aren't used by
addons anyway. The mesh RNA properties can be removed in 4.0 (T100153).

Diff Detail

Repository: rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.May 31 2022, 10:03 AM

Hans Goudey (HooglyBoogly) created this revision.

Hans Goudey (HooglyBoogly) added a reviewer: Brecht Van Lommel (brecht).May 31 2022, 6:50 PM

I am fine with the change. We should get feedback from @Joseph Eagar (joeedh) if it would still be needed in the future.

We definitely will not need this in the future.

But I don't see where the RNA API was hidden behind an experimental flag? I think this is breaking API compatibility, strictly speaking, and if the only reason is to cleanup code it may be better not to do that.