Differential D1507
BGE: Save screenshots in a different thread Authored by Sybren A. Stüvel (sybren) on Sep 7 2015, 11:34 AM. Tags Subscribers None
Details This patch allows the game engine to keep running while performing things like PNG compression and disk I/O. As an example, my crowd simulation rasterizer saves a screenshot for every frame. This now takes up 13 msec per frame, which was 31 msec before this patch. Effectively, it allows the simulation to save every frame and still run at 60 FPS.
Diff Detail
Event TimelineComment Actions Demo blend file . Press [P] to start.Without this patch: logic takes approximately 30 msec per frame, with a 30 FPS frame rate. Comment Actions Blender player doesn't use that, why ? Can you share this move this code in RAS_ICanvas to share it for blender player ?
Comment Actions Moved common code to RAS_ICanvas, using it from both Blender and Player.
Comment Actions Overall, looks good to me; just some style preferences for more defensive programming. Have you made sure to test for new memory errors with something like Valgrind? I'm guessing you've also tested both the embedded player and the Blenderplayer?
Comment Actions Moved save_screenshot_thread_func and ScreenshotTaskData out of Comment Actions Something that we'll need to think about as we use BLI_task in more and more places in the BGE, is how we want to instantiate the task scheduler and pools. Should there be a mostly global location (like KX_KetsjiEngine) where we do this, or should individual components be responsible for their own schedulers? In this case, I'm okay with the canvas having it's own since it doesn't need to manage task dependencies. It's really just using BLI_task as a higher-level threading API to launch one thread.
Comment Actions In this case, I did it to prevent a dependency cycle between KX_KetsjiEngine and the canvas. The canvas is created first, so getting it to use the engine's task pool would become hairy. I agree that it may be a good idea to have some globally-available task scheduler. However, creating one with proper task scheduling isn't trivial, but at least a global BLI_task may be a good start.
This comment was removed by Porteries Tristan (panzergame). Comment Actions Testing with Valgrind (memcheck) and Helgrind would be nice. Otherwise, looks good to me. | |||||||||||||||||||||||||||||||||||||||||||||