Paths

Table of Contentst

Differential D15083

Fix T98454: Subdivision doesn't propagate int attributes.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on May 31 2022, 6:50 PM.

Tags

None

Subscribers

None

Details

Reviewers

Hans Goudey (HooglyBoogly)

Maniphest Tasks

T98454: Geometry Nodes: Vertices from Subdivided Curve to Mesh geometry don't inherit Integer Attributes

Commits

rBdc389a61529d: Fix T98454: subdivision doesn't propagate int attributes

Summary

Subdivision surface code uses custom data layer interpolation. That wasn't implemented for int attributes yet.

Diff Detail

Repository

Branch

int-propagate (branched from master)

Build Status

Buildable 22358
Build 22358: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.May 31 2022, 6:50 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B22358: Diff 52087.May 31 2022, 6:51 PM

https://builder.blender.org/admin/#/builders/18/builds/452

Assuming the test passes (makes sense that it would), this looks good to me.

source/blender/blenkernel/intern/customdata.cc
527	What about adding a `using blender::IndexRange` at the top of the file here? I've wanted to use `IndexRange` elsewhere in this file in various patches ;)

This revision is now accepted and ready to land.May 31 2022, 7:04 PM

Closed by commit rBdc389a61529d: Fix T98454: subdivision doesn't propagate int attributes (authored by Jacques Lucke (JacquesLucke)). · Explain WhyMay 31 2022, 7:24 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rBdc389a61529d: Fix T98454: subdivision doesn't propagate int attributes.

Revision Contents
Changeset List

Path

Size

source/

blender/

blenkernel/

intern/

18 lines

Diff 52087

source/blender/blenkernel/intern/customdata.cc

Loading...