Page MenuHome
Differential D15087

Fix T98520: Sculpt operators can unintentionally clear multires mask
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jun 1 2022, 10:41 AM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T98520: Regression: Sculpt Mode: Operators can unintentionally clear multires mask
Commits
rBd3b3d7230376: Fix T98520: Sculpt operators can unintentionally clear multires mask
Summary

Typo in rBcf69652618fe: Cleanup: Use const when retrieving custom data layers.

Diff Detail

Repository
rB Blender
Branch
T98520 (branched from master)
Build Status
Buildable 22364
Build 22364: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Jun 1 2022, 10:41 AM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B22364: Diff 52110.Jun 1 2022, 10:41 AM
Philipp Oeser (lichtwerk) added projects: Sculpt, Paint & Texture, Modeling.Jun 1 2022, 10:41 AM
Hans Goudey (HooglyBoogly) accepted this revision.Jun 1 2022, 10:44 AM

Thanks for finding this.

source/blender/blenkernel/intern/subdiv_ccg_mask.c
158

I guess even more idiomatic would be if (!CustomData_has_layer(... either way is okay with me though.

This revision is now accepted and ready to land.Jun 1 2022, 10:44 AM
Closed by commit rBd3b3d7230376: Fix T98520: Sculpt operators can unintentionally clear multires mask (authored by Philipp Oeser (lichtwerk)). · Explain WhyJun 1 2022, 10:49 AM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBd3b3d7230376: Fix T98520: Sculpt operators can unintentionally clear multires mask.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
2 lines

Diff 52110

View Options

source/blender/blenkernel/intern/subdiv_ccg_mask.c

Loading...