BGE: Fix T27322: World F-Curve
ClosedPublic
Actions

Authored by Thomas Szepe (hg1) on Dec 29 2013, 3:59 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Mitchell Stokes (moguri)

Commits

Summary

This patch fixes the world (mist, background, ambient) F-Curve for for the BGE.

The patch depends on https://developer.blender.org/D149 (no merge conflicts).

Looks good to me.

I've made some inline notes. The big one that needs to be addressed is BL_ConvertWorldIpos() not returning NULL.

source/gameengine/Ketsji/BL_Action.cpp
153	Your BL_ConvertWorldIpos() will always return a non-NULL pointer, which means every single action the BGE will also try to play a world IPO, which isn't what we want. Take a look at BL_CreateObColorIPO() or BL_CreateMaterialIpo() for examples of how to fix this.
source/gameengine/Ketsji/KX_IpoConvert.cpp
275	This should be renamed to BL_CreateWorldIPO() to match the other functions.
source/gameengine/Ketsji/KX_WorldIpoController.h
50	These should probably be done as a bitfield, but this will be okay for now.