Page MenuHome
Differential D15103

Fixed selection indication for virtual socket on nodes
ClosedPublic
Actions

Authored by Max Edge (bbbooo3) on Jun 2 2022, 3:24 PM.

Details

Reviewers
Pablo Vazquez (pablovazquez)
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T94621: When the empty socket of the Group Input/Output node is selected, there is no visual feedback
Commits
rB56435b3268bc: Fix T94621: Missing selection indication for virtual node sockets
Summary

A small regression as a result of adding a custom outline to the empty virtual socket, which ended up overriding the colors when selected with Shift+LMB.
Original bug report: T94621

Diff Detail

Event Timeline

Max Edge (bbbooo3) requested review of this revision.Jun 2 2022, 3:24 PM
Max Edge (bbbooo3) created this revision.
Max Edge (bbbooo3) added a reviewer: Hans Goudey (HooglyBoogly).Jun 2 2022, 3:30 PM
Max Edge (bbbooo3) added subscribers: Dalai Felinto (dfelinto), Yuro (Yuro).
Hans Goudey (HooglyBoogly) added a task: T94621: When the empty socket of the Group Input/Output node is selected, there is no visual feedback.Jun 2 2022, 3:40 PM
Hans Goudey (HooglyBoogly) edited the summary of this revision. (Show Details)
Hans Goudey (HooglyBoogly) set the repository for this revision to rB Blender.
Hans Goudey (HooglyBoogly) removed a subscriber: Dalai Felinto (dfelinto).
Hans Goudey (HooglyBoogly) accepted this revision.Jun 3 2022, 3:36 PM

This looks sensible to me, thanks for the patch.

source/blender/editors/space_node/node_draw.cc
748–749

This comment would probably make more sense inside of the else if block, to keep it local to what it's talking about.

This revision is now accepted and ready to land.Jun 3 2022, 3:36 PM
Yuro (Yuro) added a comment.Jun 23 2022, 2:37 AM

Hi, it's been two weeks, is this patch stuck?

Yuro (Yuro) awarded a token.Jun 23 2022, 2:37 AM
Hans Goudey (HooglyBoogly) added a comment.Jun 23 2022, 6:00 PM

Nope, I just didn't get to commit it yet, I will today.

Leon Schittek (lone_noel) awarded a token.Jun 23 2022, 6:14 PM
Closed by commit rB56435b3268bc: Fix T94621: Missing selection indication for virtual node sockets (authored by Max Edge (bbbooo3), committed by Hans Goudey (HooglyBoogly)). · Explain WhyJun 23 2022, 7:22 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rB56435b3268bc: Fix T94621: Missing selection indication for virtual node sockets.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_node/
11 lines

Diff 52169

View Options

source/blender/editors/space_node/node_draw.cc

Loading...