Page MenuHome
Differential D15105

Fix T98556: Crash with extrude node in edit mode
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Jun 2 2022, 5:45 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Maniphest Tasks
T98556: Geometry nodes crash entering editmode with a UV Editor open when using an Extrude node
Commits
rB2d9c5f3dcf2e: Fix T98556: Crash with extrude node in edit mode
Summary

The original index layer was not initialized properly.
Supporting original indices properly for this node is
doable, but for now it is better to simply initialize them
to the "none" value to fix the crash.

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Jun 2 2022, 5:45 PM
Hans Goudey (HooglyBoogly) created this revision.
Jacques Lucke (JacquesLucke) accepted this revision.Jun 2 2022, 5:48 PM
Jacques Lucke (JacquesLucke) added inline comments.
source/blender/nodes/geometry/nodes/node_geo_extrude_mesh.cc
324

Technically this check is not necessary I think.

This revision is now accepted and ready to land.Jun 2 2022, 5:48 PM
Hans Goudey (HooglyBoogly) added a task: T98556: Geometry nodes crash entering editmode with a UV Editor open when using an Extrude node.Jun 2 2022, 5:53 PM
Hans Goudey (HooglyBoogly) marked an inline comment as done.
Closed by commit rB2d9c5f3dcf2e: Fix T98556: Crash with extrude node in edit mode (authored by Hans Goudey (HooglyBoogly)). · Explain WhyJun 2 2022, 5:54 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rB2d9c5f3dcf2e: Fix T98556: Crash with extrude node in edit mode.

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
72 lines

Diff 52177

View Options

source/blender/nodes/geometry/nodes/node_geo_extrude_mesh.cc

Loading...