Page MenuHome
Differential D15113

Fix T98565: remove unused BRUSH_PAINT icon definition
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Jun 3 2022, 1:34 PM.

Details

Reviewers
Julien Kaspar (JulienKaspar)
Dalai Felinto (dfelinto)
Joseph Eagar (joeedh)
Maniphest Tasks
T98565: Regression: Error in console for unknown/unused BRUSH_PAINT icon
Commits
rB1ea1b73e497c: Fix T98565: remove unused BRUSH_PAINT icon definition
rBb52760a0236f: Fix T98565: remove unused BRUSH_PAINT icon definition
Summary

This could spam the console with errors (potentionally slowing down in
cases).

Was added in rBeae36be372a6, but I think tool icons are handled
differently (dont need the definition in UI_icons.h?)

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Jun 3 2022, 1:34 PM
Philipp Oeser (lichtwerk) created this revision.
Harbormaster completed remote builds in B22411: Diff 52213.Jun 3 2022, 1:34 PM
Philipp Oeser (lichtwerk) added projects: Sculpt, Paint & Texture, User Interface.Jun 3 2022, 1:34 PM
Philipp Oeser (lichtwerk) added a reviewer: Joseph Eagar (joeedh).Jun 7 2022, 8:37 AM
Dalai Felinto (dfelinto) added 1 blocking reviewer(s): Joseph Eagar (joeedh).Jun 7 2022, 12:50 PM

It seems a reasonable fix. @Joseph Eagar (joeedh) ? Do you recall why you added this?

Joseph Eagar (joeedh) added a comment.Jun 7 2022, 4:43 PM
In D15113#408327, @Dalai Felinto (dfelinto) wrote:

It seems a reasonable fix. @Joseph Eagar (joeedh) ? Do you recall why you added this?

I think it's for the preview icon, but I don't think I ever added any. Might as well remove it for now.

Joseph Eagar (joeedh) accepted this revision.Jun 7 2022, 4:43 PM
This revision is now accepted and ready to land.Jun 7 2022, 4:43 PM
Closed by commit rBb52760a0236f: Fix T98565: remove unused BRUSH_PAINT icon definition (authored by Philipp Oeser (lichtwerk)). · Explain WhyJun 8 2022, 11:30 AM
This revision was automatically updated to reflect the committed changes.
Philipp Oeser (lichtwerk) added a commit: rBb52760a0236f: Fix T98565: remove unused BRUSH_PAINT icon definition.
Philipp Oeser (lichtwerk) added a commit: rB1ea1b73e497c: Fix T98565: remove unused BRUSH_PAINT icon definition.Jun 22 2022, 1:03 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
include/
1 line

Diff 52366

View Options

source/blender/editors/include/UI_icons.h

Loading...