Fix T98624: Curve Pen NURBS extrusion creates duplicates
ClosedPublic
Actions

Authored by Dilith Jayakody (dilithjay) on Jun 7 2022, 6:27 AM.

Details

Reviewers

Maniphest Tasks

T98624: Curve pen creates duplicate control points

Commits

rB6b82a2fce2dd: Fix T98624: Curve Pen NURBS extrusion creates duplicates
rB520be607e8ba: Fix T98624: Curve Pen NURBS extrusion creates duplicates

Summary

The initial point count check was only being done for Bezier curves.
This revision fixes T98624 by adding the check for NURBS curves as well.

Diff Detail

Repository

rB Blender

Branch

fix-t98624 (branched from master)

Build Status

Buildable 22442
Build 22442: arc lint + arc unit

Event Timeline

Dilith Jayakody (dilithjay) requested review of this revision.Jun 7 2022, 6:27 AM

Dilith Jayakody (dilithjay) created this revision.

Harbormaster completed remote builds in B22442: Diff 52322.Jun 7 2022, 6:27 AM

Dilith Jayakody (dilithjay) edited the summary of this revision. (Show Details)Jun 7 2022, 6:28 AM

Dilith Jayakody (dilithjay) edited the summary of this revision. (Show Details)

Dilith Jayakody (dilithjay) added a task: T98624: Curve pen creates duplicate control points.

Thanks for the fix. I think this should just go to master, it's a bit late in 3.2 for these small fixes.

This revision is now accepted and ready to land.Jun 7 2022, 9:08 AM

Closed by commit rB520be607e8ba: Fix T98624: Curve Pen NURBS extrusion creates duplicates (authored by Dilith Jayakody (dilithjay)). · Explain WhyJun 8 2022, 3:08 PM

This revision was automatically updated to reflect the committed changes.

Dilith Jayakody (dilithjay) added a commit: rB520be607e8ba: Fix T98624: Curve Pen NURBS extrusion creates duplicates.

Philipp Oeser (lichtwerk) added a commit: rB6b82a2fce2dd: Fix T98624: Curve Pen NURBS extrusion creates duplicates.Jun 22 2022, 1:03 PM

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

curve/

editcurve_pen.c

2 lines

Diff 52322

View Options

source/blender/editors/curve/editcurve_pen.c

Fix T98624: Curve Pen NURBS extrusion creates duplicatesClosedPublicActions