Page MenuHome
Differential D15147

Fix T98091 EEVEE: Volume: Crash caused by non-present grid
ClosedPublic
Actions

Authored by Clément Foucault (fclem) on Jun 7 2022, 5:48 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rB60442b0292bc: Fix T98091: EEVEE: Volume: Crash caused by non-present grid
Summary

This was caused by the copy_m4_m4 trying to copy the object_to_texture
from drw_grid which was nullptr.

Fixing this also exposed that rendering such volumes (without any valid
grid attributes) is not supported and we should follow what Cycles does.

Diff Detail

Repository
rB Blender
Branch
blender-v3.2-release
Build Status
Buildable 22458
Build 22458: arc lint + arc unit

Event Timeline

Clément Foucault (fclem) requested review of this revision.Jun 7 2022, 5:48 PM
Clément Foucault (fclem) created this revision.
Harbormaster completed remote builds in B22455: Diff 52351.Jun 7 2022, 5:48 PM
Brecht Van Lommel (brecht) requested changes to this revision.Jun 7 2022, 6:06 PM
Brecht Van Lommel (brecht) added inline comments.
source/blender/draw/intern/draw_volume.cc
151

I think this should be (drw_grid) ?. Otherwise this could still crash if the grid exists but failed to be allocated on the GPU.

This revision now requires changes to proceed.Jun 7 2022, 6:06 PM
Brecht Van Lommel (brecht) added a comment.Jun 7 2022, 6:08 PM

Assuming you make that simple change, no need to wait for me to review again of course.

Clément Foucault (fclem) updated this revision to Diff 52354.Jun 7 2022, 6:10 PM
  • Address review comment
Harbormaster completed remote builds in B22458: Diff 52354.Jun 7 2022, 6:10 PM
Brecht Van Lommel (brecht) accepted this revision.Jun 7 2022, 6:11 PM
This revision is now accepted and ready to land.Jun 7 2022, 6:11 PM
Closed by commit rB60442b0292bc: Fix T98091: EEVEE: Volume: Crash caused by non-present grid (authored by Clément Foucault (fclem)). · Explain WhyJun 7 2022, 6:13 PM
This revision was automatically updated to reflect the committed changes.
Clément Foucault (fclem) marked an inline comment as done.
Clément Foucault (fclem) added a commit: rB60442b0292bc: Fix T98091: EEVEE: Volume: Crash caused by non-present grid.

Revision Contents
Changeset List

PathSize
source/
blender/
draw/
intern/
2 lines
12 lines

Diff 52354

View Options

source/blender/draw/intern/draw_common.h

Loading...
View Options

source/blender/draw/intern/draw_volume.cc

Loading...